refactor: Use auth state instead of routes!

libs/shared-web/src/constants/index.ts

@@ -1,3 +1,2 @@
 export * from './routes.enum';
 export * from './BaseEnvironmentEnum';
-export * from './unprotected-routes.const';

libs/shared-web/src/providers/AuthProvider.tsx

@@ -1,9 +1,10 @@
 import React, { useContext } from 'react';
 import { IOrganizationEntity, IUserEntity, IJwtPayload } from '@novu/shared';
-import { useAuthController, useFeatureFlags } from '../hooks';
+import { useAuthController } from '../hooks';
 
 type UserContext = {
   token: string | null;
+  isLoggedIn: boolean;
   currentUser: IUserEntity | undefined;
   isUserLoading: boolean;
   currentOrganization: IOrganizationEntity | undefined;
@@ -15,6 +16,7 @@ type UserContext = {
 
 const AuthContext = React.createContext<UserContext>({
   token: null,
+  isLoggedIn: false,
   currentUser: undefined,
   isUserLoading: true,
   setToken: undefined as any,
@@ -27,12 +29,14 @@ const AuthContext = React.createContext<UserContext>({
 export const useAuthContext = (): UserContext => useContext(AuthContext);
 
 export const AuthProvider = ({ children }: { children: React.ReactNode }) => {
-  const { token, setToken, user, organization, isUserLoading, logout, jwtPayload, organizations } = useAuthController();
+  const { token, setToken, user, organization, isUserLoading, logout, jwtPayload, organizations, isLoggedIn } =
+    useAuthController();
 
   return (
     <AuthContext.Provider
       value={{
         currentUser: user,
+        isLoggedIn,
         isUserLoading,
         currentOrganization: organization,
         organizations,

libs/shared-web/src/providers/LaunchDarklyProvider.tsx

@@ -3,7 +3,7 @@ import { asyncWithLDProvider } from 'launchdarkly-react-client-sdk';
 import { PropsWithChildren, ReactNode, useEffect, useRef, useState } from 'react';
 import { LAUNCH_DARKLY_CLIENT_SIDE_ID } from '../config';
 import { useFeatureFlags } from '../hooks';
-import { checkIsUnprotectedPathname, checkShouldUseLaunchDarkly } from '../utils';
+import { checkShouldUseLaunchDarkly } from '../utils';
 import { useAuthContext } from './AuthProvider';
 
 /** A provider with children required */
@@ -33,7 +33,7 @@ export const LaunchDarklyProvider: React.FC<PropsWithChildren<ILaunchDarklyProvi
   if (!authContext) {
     throw new Error('LaunchDarklyProvider must be used within <AuthProvider>!');
   }
-  const { currentOrganization } = authContext;
+  const { currentOrganization, isLoggedIn } = authContext;
 
   useEffect(() => {
     // no need to fetch if LD is disabled or there isn't an org to query against
@@ -61,9 +61,9 @@ export const LaunchDarklyProvider: React.FC<PropsWithChildren<ILaunchDarklyProvi
 
   /**
    * For self-hosted, LD will not be enabled, so do not block initialization.
-   * Checking unprotected (routes without org-based auth) is required to ensure that such routes still load.
+   * Must not show the fallback if the user isn't logged-in to avoid issues with un-authenticated routes (i.e. login).
    */
-  if (checkShouldUseLaunchDarkly() && !checkIsUnprotectedPathname(window.location.pathname) && !isLDReady) {
+  if (checkShouldUseLaunchDarkly() && isLoggedIn && !isLDReady) {
     return <>{fallbackDisplay}</>;
   }
 

libs/shared-web/src/utils/index.ts

@@ -1,3 +1,2 @@
 export * from './segment';
-export * from './checkIsUnprotectedPathname';
 export * from './checkShouldUseLaunchDarkly';