Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): decommission old instance of redis cluster #4824

Merged
merged 2 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions apps/worker/src/app/workflow/services/cold-start.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,15 @@ import { INestApplication } from '@nestjs/common';
import { INovuWorker, ReadinessService } from '@novu/application-generic';

import { StandardWorker } from './standard.worker';
import { WorkflowWorker } from './workflow.worker';
import { OldInstanceStandardWorker } from './old-instance-standard.worker';
import { OldInstanceWorkflowWorker } from './old-instance-workflow.worker';
import { SubscriberProcessWorker } from './subscriber-process.worker';
import { WorkflowWorker } from './workflow.worker';

/**
* TODO: Temporary engage OldInstanceWorkflowWorker while migrating to MemoryDB
*/
const getWorkers = (app: INestApplication): INovuWorker[] => {
const standardWorker = app.get(StandardWorker, { strict: false });
const workflowWorker = app.get(WorkflowWorker, { strict: false });
const oldInstanceStandardWorker = app.get(OldInstanceStandardWorker, { strict: false });
const oldInstanceWorkflowWorker = app.get(OldInstanceWorkflowWorker, { strict: false });
const subscriberProcessWorker = app.get(SubscriberProcessWorker, { strict: false });

const workers: INovuWorker[] = [
standardWorker,
workflowWorker,
oldInstanceStandardWorker,
oldInstanceWorkflowWorker,
subscriberProcessWorker,
];
const workers: INovuWorker[] = [standardWorker, workflowWorker, subscriberProcessWorker];

return workers;
};
Expand Down
2 changes: 0 additions & 2 deletions apps/worker/src/app/workflow/services/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@ export * from './active-jobs-metric.service';
export * from './completed-jobs-metric.service';
export * from './standard.worker';
export * from './workflow.worker';
export * from './old-instance-standard.worker';
export * from './old-instance-workflow.worker';
199 changes: 0 additions & 199 deletions apps/worker/src/app/workflow/services/old-instance-standard.worker.ts

This file was deleted.

This file was deleted.

13 changes: 1 addition & 12 deletions apps/worker/src/app/workflow/workflow.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
GetSubscriberGlobalPreference,
GetSubscriberTemplatePreference,
ProcessTenant,
OldInstanceBullMqService,
QueuesModule,
SelectIntegration,
SendTestEmail,
Expand All @@ -33,14 +32,7 @@ import {
} from '@novu/application-generic';
import { JobRepository } from '@novu/dal';

import {
ActiveJobsMetricService,
CompletedJobsMetricService,
StandardWorker,
WorkflowWorker,
OldInstanceWorkflowWorker,
OldInstanceStandardWorker,
} from './services';
import { ActiveJobsMetricService, CompletedJobsMetricService, StandardWorker, WorkflowWorker } from './services';

import {
MessageMatcher,
Expand Down Expand Up @@ -123,9 +115,6 @@ const PROVIDERS: Provider[] = [
StandardWorker,
WorkflowWorker,
SubscriberProcessWorker,
OldInstanceBullMqService,
OldInstanceStandardWorker,
OldInstanceWorkflowWorker,
];

@Module({
Expand Down
2 changes: 0 additions & 2 deletions apps/ws/src/socket/services/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export { OldInstanceWebSocketsWorker } from './old-instance-web-sockets.worker';
export { OldInstanceWebSocketsWorkerService } from './old-instance-web-sockets-worker.service';
export { WebSocketWorker } from './web-socket.worker';
Loading