-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): add sdk methods for organization apis #4826
feat(node): add sdk methods for organization apis #4826
Conversation
list(); | ||
create(payload: IOrganizationCreatePayload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these two methods are public? For me it doesn't make sense - API KEY is attached to single organization, so why we want to allow to cross that boundary?
Whose organizations will be returned? Organizations of the owner?
I'm just wondering - but I implemented that anyway.
removeMember(memberId: string); | ||
updateMemberRole( | ||
memberId: string, | ||
payload: IOrganizationUpdateMemberRolePayload | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two methods also may cause problems when full Role-based access control will be implemented?
I can imagine member that may bypass role-based access control by using API KEY to remove other members or update their role - they will do it as "organization owner" (assuming that member would be able to see api key).
Thanks for your contribution @michaldziuba03 |
What change does this PR introduce?
This PR introduces new SDK methods for organization API.
Why was this change needed?
Closes #4775
Other information (Screenshots)