Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent github email change from creating a new account #4833

Closed
wants to merge 1 commit into from

Conversation

gitstart
Copy link
Contributor

What change does this PR introduce?

This changes ensure users retain their account when their github's primary email is updated.

Why was this change needed?

New account is created for users that uses github authentication provider, when they update their github account's primary email address.

Other information

closes #2964


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart gitstart changed the title NV-1815 - 🐛 Bug Report: GitHub email change = new account fix: prevent github email change from creating a new account Nov 13, 2023
@gitstart gitstart marked this pull request as ready for review November 13, 2023 12:00
@gitstart
Copy link
Contributor Author

@djabarovgeorge @p-fernandez this PR is ready for review

@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Nov 27, 2023
@scopsy
Copy link
Contributor

scopsy commented Apr 7, 2024

Closing due to inactivity.

@scopsy scopsy closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@novu/api @novu/dal stale Pull Request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-1815] 🐛 Bug Report: GitHub email change = new account
2 participants