-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add evaluate api rate limit use case #4844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…future rate limited protocols
…fault-api-rate-limits use-case
…vuhq/novu into nv-3059-get-rate-limit-use-case
…60-modified-token-bucket-algorithm
…60-modified-token-bucket-algorithm
…60-modified-token-bucket-algorithm
…60-modified-token-bucket-algorithm
…60-modified-token-bucket-algorithm
…imit config module
…orrect environment ID on
…60-modified-token-bucket-algorithm
…ithub.com/novuhq/novu into nv-3060-token-bucket-rate-limiting-use-case
…oken-bucket-rate-limiting-use-case
LetItRock
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks perfect to me! 💎
...pi/src/app/rate-limiting/usecases/evaluate-api-rate-limit/evaluate-api-rate-limit.usecase.ts
Outdated
Show resolved
Hide resolved
.../app/rate-limiting/usecases/get-api-rate-limit-maximum/get-api-rate-limit-maximum.usecase.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
evaluate-api-rate-limit
use-case to determine if a request should be rate-limited for a givenenvironmentId
, service category, and cost category.evaluate-token-bucket-rate-limit
use-case to encapsulate the token bucket algorithm. The use-case uses the@upstash/ratelimit
library to implement the token bucket rate limit algorithm.Why was this change needed?
evaluate-api-rate-limit
use-case will be used in the Rate Limiting guard to determine if a request will be accepted or rejectedOther information (Screenshots)
N/A