feat: add nginx based docker compose #5498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainpawan21
requested review from
scopsy and
Cliftonz
and removed request for
a team
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cliftonz
reviewed
May 5, 2024
| VIRTUAL_HOST: ${REACT_APP_WS_HOST} | ||
| VIRTUAL_PORT: ${WS_PORT} | ||
| LETSENCRYPT_HOST: ${REACT_APP_WS_HOST} | ||
| LETSENCRYPT_EMAIL: ${LETSENCRYPT_EMAIL} |
There was a problem hiding this comment.
How does the system leverage this env variable?
There was a problem hiding this comment.
LetItRock
reviewed
May 8, 2024
| WIDGET_PORT=4500 | ||
|
|
||
| # Hosts | ||
| REACT_APP_WS_HOST=ws.novu.domain.com |
There was a problem hiding this comment.
Suggested change
| REACT_APP_WS_HOST=ws.novu.domain.com | |
| WS_HOST=ws.novu.domain.com |
| MONGO_MIN_POOL_SIZE=100 | ||
| MONGO_INITDB_ROOT_USERNAME=novu-selfhost | ||
| MONGO_INITDB_ROOT_PASSWORD=qwertyuiop | ||
| MONGO_URL=mongodb://novu-selfhost:qwertyuiop@mongodb:27017/novu-db?authSource=admin |
There was a problem hiding this comment.
Suggested change
| MONGO_URL=mongodb://novu-selfhost:qwertyuiop@mongodb:27017/novu-db?authSource=admin | |
| MONGO_URL=mongodb://$MONGO_INITDB_ROOT_USERNAME:$MONGO_INITDB_ROOT_PASSWORD@mongodb:27017/novu-db?authSource=admin |
Comment on lines
+34
to
+35
| - nginx-proxy | ||
| - nginx-proxy-acme |
There was a problem hiding this comment.
nginx-proxy-acme depends on nginx-proxy, so we can just have nginx-proxy-acme here and in some other places as well
| MONGO_MAX_POOL_SIZE: ${MONGO_MAX_POOL_SIZE} | ||
| REDIS_HOST: ${REDIS_HOST} | ||
| REDIS_PORT: ${REDIS_PORT} | ||
| REDIS_DB_INDEX: 2 |
There was a problem hiding this comment.
let's have this in the variable as well
|
This PR is being marked as stale due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
add nginx based reverse proxy setup with lets encrypt
Docs PR:- novuhq/docs#587
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer