fix(client): Save step template form on unmount to handle esc key #7444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
approved these changes
Jan 7, 2025
Comment on lines
66
to
73
| const saveFormRef = useRef(saveForm); | ||
| useEffect(() => { | ||
| saveFormRef.current = saveForm; | ||
| }, [saveForm]); | ||
| useEffect(() => { | ||
| return () => { | ||
| saveFormRef.current(); | ||
| }; | ||
| }, [saveFormRef]); |
There was a problem hiding this comment.
Suggested change
| const saveFormRef = useRef(saveForm); | |
| useEffect(() => { | |
| saveFormRef.current = saveForm; | |
| }, [saveForm]); | |
| useEffect(() => { | |
| return () => { | |
| saveFormRef.current(); | |
| }; | |
| }, [saveFormRef]); | |
| const saveFormRef = useDataRef(saveForm); | |
| useEffect(() => { | |
| return () => { | |
| saveFormRef.current(); | |
| }; | |
| }, [saveFormRef]); |
desiprisg
force-pushed
the
nv-4952-polishdashboard-editor-missing-save-on-escape-button-click
branch
from
115aeff to
39a389a
Compare
desiprisg
deleted the
nv-4952-polishdashboard-editor-missing-save-on-escape-button-click
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer