fix(web,api-service): redirect edit action of v1 workflows to old web app when opt-in #7460
Conversation
LetItRock
requested review from
SokratisVidros,
scopsy,
BiswaViraj,
ChmaraX,
djabarovgeorge and
desiprisg
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| if (typeof template.type === 'undefined' && typeof template.origin === 'undefined') { | ||
| return WorkflowOriginEnum.NOVU_CLOUD_V1; | ||
| } |
There was a problem hiding this comment.
This fixes the workflow badge in the Dashboard workflows list page.
The old v1 workflows like I do have in prod don't have type and origin fields that were introduced later. In that case the origin of the workflow is v1.
| switch (currentRoute) { | ||
| case ROUTES.GET_STARTED: | ||
| return `${newDashboardUrl}/env/${environment?.slug}/welcome`; | ||
| case ROUTES.WORKFLOWS: | ||
| return `${newDashboardUrl}/env/${environment?.slug}/workflows`; | ||
| case ROUTES.ACTIVITIES: | ||
| return `${newDashboardUrl}/env/${environment?.slug}/activity-feed`; | ||
| case ROUTES.INTEGRATIONS: | ||
| return `${newDashboardUrl}/integrations`; | ||
| case ROUTES.API_KEYS: | ||
| return `${newDashboardUrl}/env/${environment?.slug}/api-keys`; | ||
| default: | ||
| return undefined; |
There was a problem hiding this comment.
Based on the Web application's current route calculate the new Dashboard URL and redirect the user when he is opt-in.
There was a problem hiding this comment.
I had to refactor the previous code because we want to allow editing the v1 workflows in the old Web app if the user is opt-in. Also at the same time clicking in the side navigation in the Web app should redirect user to the new Dashboard corresponding page.
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What changed? Why was the change needed?
Redirect the edit v1 workflow action to the old Web application when the user is opt-in.
Also, improve the logic of redirecting to the new Dashboard pages in the Web app.
Screenshots
Screen.Recording.2025-01-08.at.15.10.15.mov