Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(root, api-service, worker, ws, webhook): migrate from aws ssm to aws secret manager" #7466

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

merrcury
Copy link
Member

@merrcury merrcury commented Jan 8, 2025

Reverts #7409

@merrcury merrcury requested a review from a team as a code owner January 8, 2025 16:46
@merrcury merrcury requested review from SokratisVidros and scopsy and removed request for a team January 8, 2025 16:46
Copy link

linear bot commented Jan 8, 2025

Copy link

github-actions bot commented Jan 8, 2025

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Your PR title is: Revert "feat(root, api-service, worker, ws, webhook): migrate from aws ssm to aws secret manager"
It should be something like: feat(scope): Add fancy new feature

Details:

No release type found in pull request title "Revert "feat(root, api-service, worker, ws, webhook): migrate from aws ssm to aws secret manager"". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit ea2d6c7
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/677eabdcb01a2a00080faa21
😎 Deploy Preview https://deploy-preview-7466.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@merrcury merrcury merged commit 3f0efc0 into next Jan 8, 2025
25 of 27 checks passed
@merrcury merrcury deleted the revert-7409-feat/secretManager branch January 8, 2025 16:48
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit ea2d6c7
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/677eabdc9716e9000810697c
😎 Deploy Preview https://deploy-preview-7466.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants