fix(application-generic): potential get preferences performance improvement #7467
Conversation
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const workflowPreferences: ISubscriberPreferenceResponse[] = | ||
| this.calculateWorkflowPreferences( | ||
| workflowList, | ||
| workflowPreferenceSets, | ||
| subscriberGlobalPreference, | ||
| command.includeInactiveChannels, | ||
| ); | ||
|
|
||
| const nonCriticalWorkflowPreferences = workflowPreferences.filter( | ||
| (preference) => !preference.template.critical, | ||
| ); | ||
|
|
||
| return nonCriticalWorkflowPreferences; | ||
| } |
There was a problem hiding this comment.
all I did in this file is moved the code parts to the class functions to be able to instrument them and see the perf bottleneck
| const mergedPreferences = deepMerge( | ||
| preferencesList as DeepRequired<PreferencesEntity>[], | ||
| ); | ||
| const mergedPreferences = merge({}, ...preferencesList); |
There was a problem hiding this comment.
We assume that the potential issue of slow response times could be that we used the custom deepMerge code that was copied from the lib and had not been maintained for the last 2 years. We want to verify that assumption.
There was a problem hiding this comment.
@LetItRock Nice!
If the hypothesis is verified we should do a follow up PR, and remove the deepMerge utility from the code base as it's used in two more occasions.
| @@ -1,9 +1,8 @@ | |||
| import { merge } from 'lodash'; | |||
There was a problem hiding this comment.
For 100% manual tree shaking
| import { merge } from 'lodash'; | |
| import merge from 'lodash/merge'; |
There was a problem hiding this comment.
ahh yeah missed that
LetItRock
deleted the
potential-get-preferences-performance-improvement
branch
What changed? Why was the change needed?
Get subscriber preferences potential perf improvement.
Screenshots