feat(dashboard): fix on hover regression #7604
Conversation
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -219,7 +219,7 @@ export const WorkflowRow = ({ workflow }: WorkflowRowProps) => { | |||
| </WorkflowLinkTableCell> | |||
|
|
|||
| <WorkflowLinkTableCell workflow={workflow} className="text-foreground-600 min-w-[180px] text-sm font-medium"> | |||
| <TimeDisplayHoverCard date={new Date(workflow.updatedAt)}> | |||
| <TimeDisplayHoverCard date={new Date(workflow.updatedAt)} className="relative z-10"> | |||
There was a problem hiding this comment.
I wonder if it's better to add inside of the time display component so it will fix it on all screens (subscribers, etc.)
There was a problem hiding this comment.
valid point.
right now i saw that it was broken only on workflows (the activity page was fine) so i decided to do it more specifically for now,
There was a problem hiding this comment.
FYI the problem was because we made the workflow.TableRow isolate to support row Click.
There was a problem hiding this comment.
We need a universal fix on this, not just for workflows. The same problem exists in environments table.
What changed? Why was the change needed?
The date isn’t clickable. Is it a priority to make it clickable as well?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer