Fixed interactive gridlines to take into account brush when drawing points on stacked area chart #2154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the drawn points on the interactive grid line of a Stacked Area Chart do no take into account when using brush on a
StackedAreaWithFocusChart
. The line chart does not have this issue, the code that corrects this in the line chart is absent for stacked area chart.This change simply adds the logic that was done for the line chart:
nvd3/src/models/lineChart.js
Lines 290 to 299 in 254bb45
Into the StackedAreaChart.
To see this issue go to the example:
https://rawgit.com/novus/nvd3/master/examples/stackedAreaWithFocusChart.html
Then move the pan to all the way to the left. The dots on the grid line will match up, panning to the right will cause an ever growing offset of the drawn dots.
To check that the issue is fixed build this version and go to the same example:
/nvd3/master/examples/stackedAreaWithFocusChart.html
.