Updated GoogleDoc class to work with new(er) spreadsheets #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text.update now accepts a gid argument if you want to download a specific sheet
|
Hola |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
gidparameter is ignored when fetching the example spreadsheet included with the app template. However, thegidparameter does work when fetching newer spreadsheets.So, I changed the
GoogleDocclass to omit thegidparam so that all sheets in a spreadsheet will be downloaded by default. Also changed thefab text.updatecommand to accept agidargument in case you only want to fetch a specific sheet from your spreadsheet.