Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: Add hello nrf cloud OOB firmware to app index #52

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

simensrostad
Copy link
Contributor

Add hello nrf cloud OOB firmware to app index

@simensrostad simensrostad force-pushed the add-oob-app-index branch 3 times, most recently from e4aee04 to 7a1a8be Compare November 12, 2024 09:20
Copy link

@coderbyheart coderbyheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use firmware name approved by PMT.
Use correct firmware version information.

index/hello-nrfcloud.json Outdated Show resolved Hide resolved
index/hello-nrfcloud.json Outdated Show resolved Hide resolved
index/hello-nrfcloud.json Outdated Show resolved Hide resolved
index/hello-nrfcloud.json Outdated Show resolved Hide resolved
Copy link
Contributor

@FilipZajdel FilipZajdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I would like you to also make a change in the generate-index-json.ts file, line 25: add 'hello-nrfcloud' to the nordicOrgs list.

index/hello-nrfcloud.json Outdated Show resolved Hide resolved
Add hello nrf cloud OOB firmware to app index

Signed-off-by: Simen S. Røstad <[email protected]>
@FilipZajdel FilipZajdel added this pull request to the merge queue Nov 12, 2024
Merged via the queue into nrfconnect:main with commit a6a6eb1 Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants