Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: Fix memory leaks #15593

Merged
merged 5 commits into from
Jun 3, 2024
Merged

wifi: Fix memory leaks #15593

merged 5 commits into from
Jun 3, 2024

Conversation

krish2718
Copy link
Contributor

Memory leak fixes and misc improvements.

UMAC team for reviewing the removal of per-iface extended capabilities.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels May 30, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 30, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hostap nrfconnect/sdk-hostap@c947dc6 nrfconnect/sdk-hostap@e2b94fd (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 30, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-sdk-wifi X

test-sdk-wifi: added because there was no .github/test-spec.yml in 'hostap'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@krish2718 krish2718 added this to the 2.7.0 milestone May 30, 2024
@krish2718 krish2718 added the bugfix Fixes a known bug label May 30, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Fix MLME buffer memory leak.

Signed-off-by: Chaitanya Tata <[email protected]>
krish2718 added 4 commits May 31, 2024 19:38
RPU is only providing the per-wiphy (RPU) extended capabilities, so,
remove storing of per-VIF extended capabilities.

BTW, there is a memory leak here when doing interface down and up.

Fixes SHEL-2738.

Signed-off-by: Chaitanya Tata <[email protected]>
The extended capabilities are not freed causing a leak on interface down
and up.

Fixes SHEL-2738.

Signed-off-by: Chaitanya Tata <[email protected]>
Driver should only use kernel memory.

Signed-off-by: Chaitanya Tata <[email protected]>
WPA supplicant is platform agnostic, so, should always use the OS
abstraction APIs. And also for now WPA supplicant uses libc heap, so,
using kernel API is wrong.

Signed-off-by: Chaitanya Tata <[email protected]>
@rlubos rlubos merged commit f02c2c4 into nrfconnect:main Jun 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-hostap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants