-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove child/parent image support #19283
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 4d380986c80d40547c5d0605a367cae20e181de6 more detailssdk-nrf:
mcuboot:
zephyr:
Github labels
List of changed files detected by CI (150)
Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
fc29731
to
ee39911
Compare
ee39911
to
fa54878
Compare
fa54878
to
4a83180
Compare
4a83180
to
5cb647c
Compare
5cb647c
to
740d4de
Compare
cb3487d
to
d298017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving! Looking forward to doc fixes in an upcoming PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a Fast Pair issue (see comment above for details). Since it affects a non-default configuration (without sysbuild) and this PR is really a big one, I think we could agree to fix it in a separate PR
91c8a40
to
6417d76
Compare
6417d76
to
1c3ab8f
Compare
@nrfconnect/ncs-aurora-doc @nrfconnect/ncs-doc-release @nrfconnect/ncs-dragoon-doc @nrfconnect/ncs-si-bluebagel-doc please review |
1c3ab8f
to
2e2660c
Compare
Isn't a changelog entry required for this PR? |
Will be part of a followup PR that applies doc changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for SI Muffin
Memory footprint analysis revealed the following potential issuessample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 912202[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19283/43) |
Removes support for child/parent image from these repos Signed-off-by: Jamie McCrae <[email protected]>
Removes support for child/parent image Signed-off-by: Jamie McCrae <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from perspective of our apps/samples
2e2660c
to
4d38098
Compare
Removes support for this deprecated feature
test_sdk_mcuboot: sdk-nrf-19283
test_rs: PR-1443
test_fem: PR-1443