Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove child/parent image support #19283

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

nordicjm
Copy link
Contributor

@nordicjm nordicjm commented Dec 5, 2024

Removes support for this deprecated feature

test_sdk_mcuboot: sdk-nrf-19283
test_rs: PR-1443
test_fem: PR-1443

@nordicjm nordicjm added the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@nordicjm nordicjm added this to the 3.0.0 milestone Dec 5, 2024
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-Requested Approves single commit for CI tests on Internal HW ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. and removed CI-Requested Approves single commit for CI tests on Internal HW labels Dec 5, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 5, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
mcuboot nrfconnect/sdk-mcuboot@b82206c nrfconnect/sdk-mcuboot@99d4ae9 (main) nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@0ea1f14 nrfconnect/sdk-zephyr@20a2ba2 nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 5, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 43

Inputs:

Sources:

sdk-nrf: PR head: 4d380986c80d40547c5d0605a367cae20e181de6
mcuboot: PR head: 99d4ae97314c413208746f1fb272eb4ecf85b3ea
zephyr: PR head: 20a2ba291a8fd3ac3fd0f51c0491d7debbd11be4

more details

sdk-nrf:

PR head: 4d380986c80d40547c5d0605a367cae20e181de6
merge base: 588b082f9144f84fffd5f91c47186f26e596d2c0
target head (main): 82d3d2677adf85c5b9645b34f69e787fb25ff2f3
Diff

mcuboot:

PR head: 99d4ae97314c413208746f1fb272eb4ecf85b3ea
merge base: b82206c15fff357c151c24bf97c99c4348d14a46
Diff

zephyr:

PR head: 20a2ba291a8fd3ac3fd0f51c0491d7debbd11be4
merge base: 0ea1f14056a54e88b689e0c9623700d53f469563
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (150)
CMakeLists.txt
Kconfig.nrf
applications
│  ├── asset_tracker_v2
│  │  ├── boards
│  │  │  ├── native_sim.conf
│  │  │  │ thingy91_nrf9160_ns.conf
│  │  │ prj.conf
│  ├── machine_learning
│  │  │ CMakeLists.txt
│  ├── nrf5340_audio
│  │  │ Kconfig.defaults
│  ├── nrf_desktop
│  │  │ CMakeLists.txt
boards
│  ├── nordic
│  │  ├── thingy91x
│  │  │  ├── Kconfig.defconfig.nrf5340
│  │  │  ├── Kconfig.defconfig.nrf9151
│  │  │  │ Kconfig.sysbuild
bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── bootutil
│  │  │  │  ├── src
│  │  │  │  │  ├── loader_legacy_child_parent.c
│  │  │  │  │  │ swap_priv.h
│  │  │  ├── zephyr
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ext_flash.conf
│  │  │  │  ├── include
│  │  │  │  │  ├── sysflash
│  │  │  │  │  │  ├── pm_sysflash_legacy_child_parent.h
│  │  │  │  │  │  │ sysflash.h
│  │  │  │  │ pm.yml
cmake
│  ├── extensions.cmake
│  ├── fw_zip.cmake
│  ├── mesh_dfu_metadata.cmake
│  ├── multi_image.cmake
│  ├── partition_manager.cmake
│  ├── sysbuild
│  │  ├── lwm2m_carrier_divided_dfu.cmake
│  │  │ partition_manager.cmake
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── config_and_build
│  │  │  │  │ multi_image.rst
│  │  ├── external_comp
│  │  │  │ bt_fast_pair.rst
│  │  ├── libraries
│  │  │  ├── bluetooth
│  │  │  │  ├── services
│  │  │  │  │  │ fast_pair.rst
│  │  ├── protocols
│  │  │  ├── bt
│  │  │  │  ├── bt_mesh
│  │  │  │  │  │ configuring.rst
│  │  ├── releases_and_maturity
│  │  │  │ known_issues.rst
lib
│  ├── edge_impulse
│  │  │ CMakeLists.txt
modules
│  ├── mcuboot
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── boot
│  │  │  ├── zephyr
│  │  │  │  │ Kconfig
│  │  ├── hooks
│  │  │  │ nrf53_hooks.c
│  ├── trusted-firmware-m
│  │  │ CMakeLists.txt
samples
│  ├── CMakeLists.txt
│  ├── Kconfig
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── ble_peripheral_lbs_coex
│  │  │  │  │ prj.conf
│  │  │  ├── chat
│  │  │  │  │ prj.conf
│  │  │  ├── light
│  │  │  │  │ prj.conf
│  │  │  ├── light_ctrl
│  │  │  │  │ prj.conf
│  │  │  ├── light_dimmer
│  │  │  │  │ prj.conf
│  │  │  ├── light_switch
│  │  │  │  │ prj.conf
│  │  │  ├── sensor_client
│  │  │  │  │ prj.conf
│  │  │  ├── sensor_server
│  │  │  │  │ prj.conf
│  │  │  ├── silvair_enocean
│  │  │  │  │ prj.conf
│  │  ├── peripheral_uart
│  │  │  │ nrf5340dk_app_sr_net.conf
│  ├── cellular
│  │  ├── lwm2m_client
│  │  │  │ sample.yaml
│  │  ├── nrf_cloud_multi_service
│  │  │  ├── boards
│  │  │  │  │ thingy91_nrf9160_ns.conf
│  │  │  │ overlay_full_modem_fota.conf
│  │  ├── nrf_cloud_rest_fota
│  │  │  ├── overlay_full_modem_fota.conf
│  │  │  │ prj.conf
│  ├── common
│  │  ├── mcumgr_bt_ota_dfu
│  │  │  │ rpmsg_child_image_overlay.conf
│  ├── debug
│  │  ├── memfault
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp.conf
│  ├── keys
│  │  ├── hw_unique_key
│  │  │  │ prj.conf
│  ├── mpsl
│  │  ├── timeslot
│  │  │  │ prj.conf
│  ├── peripheral
│  │  ├── radio_test
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpunet.conf
│  ├── tfm
│  │  ├── provisioning_image
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp.conf
│  │  │  │ prj.conf
│  │  ├── tfm_psa_template
│  │  │  │ prj.conf
scripts
│  ├── bluetooth
│  │  ├── mesh
│  │  │  │ mesh_dfu_metadata.py
│  ├── partition_manager
│  │  │ partition_manager.rst
subsys
│  ├── CMakeLists.txt
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  │ hci_ipc_child_image_overlay.conf
│  │  ├── services
│  │  │  ├── fast_pair
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ Kconfig.fast_pair
│  ├── bootloader
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── bl_override
│  │  │  │ CMakeLists.txt
│  │  ├── cmake
│  │  │  ├── debug_keys.cmake
│  │  │  ├── provision_hex.cmake
│  │  │  │ sign.cmake
│  │  ├── image
│  │  │  ├── CMakeLists.txt
│  │  │  │ build_s1.conf
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf70_fw_ext
│  │  │  │  │ Kconfig
│  │  │  ├── nrf_cloud
│  │  │  │  ├── Kconfig.nrf_cloud_fota
│  │  │  │  │ Kconfig.nrf_cloud_pgps
│  ├── partition_manager
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  │ Kconfig.template.build_strategy
│  ├── trusted_storage
│  │  │ Kconfig
│  ├── zigbee
│  │  ├── Kconfig
│  │  ├── lib
│  │  │  ├── zigbee_fota
│  │  │  │  │ Kconfig
sysbuild
│  │ CMakeLists.txt
tests
│  ├── CMakeLists.txt
│  ├── Kconfig
│  ├── drivers
│  │  ├── flash
│  │  │  ├── flash_rpc
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── aci
│  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── prj.conf
│  │  │  │  ├── remote
│  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  │  ├── sysbuild.conf
│  │  │  │  ├── sysbuild
│  │  │  │  │  │ empty_net_core.conf
│  │  │  │  ├── testcase.yaml
│  │  │  │  ├── zephyr
│  │  │  │  │  │ module.yml
│  │  ├── fprotect
│  │  │  ├── app
│  │  │  │  │ prj.conf
│  │  │  ├── storage
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │  │ nrf54l15pdk_nrf54l15_cpuapp.conf
│  │  │  │  │ prj.conf
│  ├── lib
│  │  ├── hw_unique_key
│  │  │  │ prj.conf
│  ├── modules
│  │  ├── mcuboot
│  │  │  ├── direct_xip
│  │  │  │  ├── child_image
│  │  │  │  │  │ mcuboot.conf
│  │  │  │  │ testcase.yaml
│  │  │  ├── external_flash
│  │  │  │  ├── child_image
│  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  ├── nrf52840dk_nrf52840.overlay
│  │  │  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.conf
│  │  │  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.overlay
│  │  │  │  │  │  │  │ thingy53_nrf5340_cpuapp.conf
│  │  │  │  │  │  │ prj.conf
│  │  │  │  │ testcase.yaml
│  ├── nrf5340_audio
│  │  ├── sw_codec_lc3
│  │  │  │ prj.conf
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── mesh
│  │  │  │  ├── metadata_extraction
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │ prj.conf
│  │  │  │  ├── models
│  │  │  │  │  │ overlay-mesh-emds.conf
│  │  ├── bootloader
│  │  │  ├── bl_crypto
│  │  │  │  ├── child_image
│  │  │  │  │  │ mcuboot.conf
│  │  │  │  │ testcase.yaml
│  │  │  ├── bl_validation
│  │  │  │  │ prj.conf
│  │  │  ├── bl_validation_ff_key
│  │  │  │  ├── Kconfig
│  │  │  │  ├── prj.conf
│  │  │  │  │ sysbuild.conf
│  │  │  ├── bl_validation_neg
│  │  │  │  │ prj.conf
│  │  ├── emds
│  │  │  ├── emds_api
│  │  │  │  │ prj.conf
│  │  │  ├── emds_flash
│  │  │  │  │ prj.conf
│  │  ├── event_manager_proxy
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── aci
│  │  │  │  │ CMakeLists.txt
│  │  │  ├── boards
│  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.conf
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_icmsg.conf
│  │  │  ├── prj.conf
│  │  │  ├── prj_icmsg.conf
│  │  │  ├── zephyr
│  │  │  │  │ module.yml
│  │  ├── fw_info
│  │  │  │ prj.conf
│  │  ├── net
│  │  │  ├── lib
│  │  │  │  ├── nrf_cloud
│  │  │  │  │  ├── fota_common
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  ├── partition_manager
│  │  │  ├── region
│  │  │  │  │ prj.conf
│  │  │  ├── static_pm_file
│  │  │  │  │ testcase.yaml
│  │  ├── pcd
│  │  │  ├── child_image
│  │  │  │  │ hello_world.conf
│  │  │  │ testcase.yaml
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf5340dk
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.yaml
│  │  │  ├── nrf9160dk
│  │  │  │  ├── nrf9160dk_nrf9160_ns_0_14_0.yaml
│  │  │  │  │ nrf9160dk_nrf9160_ns_0_7_0.yaml
│  ├── cmake
│  │  ├── linker
│  │  │  ├── ld
│  │  │  │  │ target.cmake
│  │  ├── modules
│  │  │  │ kconfig.cmake
│  ├── samples
│  │  ├── subsys
│  │  │  ├── usb
│  │  │  │  ├── dfu
│  │  │  │  │  │ sysbuild.conf
│  ├── tests
│  │  ├── drivers
│  │  │  ├── flash
│  │  │  │  ├── common
│  │  │  │  │  │ sysbuild.conf

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ❌ Integration tests
    • ✅ test-sdk-audio
    • ❌ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ❌ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ❌ test-fw-nrfconnect-ble_samples
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ doc-internal
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ❌ test-fw-nrfconnect-thread
    • ❌ test-fw-nrfconnect-zigbee
    • ❌ test-sdk-find-my
    • ❌ test-fw-nrfconnect-nrf-iot_mosh
    • ❌ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-sidewalk
    • ❌ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ❌ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ❌ test-fw-nrfconnect-ps
    • ✅ test-secdom-samples-public
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud

Note: This message is automatically posted and updated by the CI

@github-actions github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@nordicjm nordicjm added the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@github-actions github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@nordicjm nordicjm added the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@github-actions github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@nordicjm nordicjm added the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@github-actions github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@nordicjm nordicjm added the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@github-actions github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Dec 5, 2024
@nordicjm nordicjm force-pushed the byebyechildparent branch 2 times, most recently from cb3487d to d298017 Compare December 5, 2024 14:46
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! Looking forward to doc fixes in an upcoming PR :)

Copy link
Contributor

@MarekPieta MarekPieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a Fast Pair issue (see comment above for details). Since it affects a non-default configuration (without sysbuild) and this PR is really a big one, I think we could agree to fix it in a separate PR

cmake/partition_manager.cmake Outdated Show resolved Hide resolved
subsys/bluetooth/services/fast_pair/CMakeLists.txt Outdated Show resolved Hide resolved
@nordicjm nordicjm requested review from Balaklaka and a team as code owners January 20, 2025 12:17
@nordicjm
Copy link
Contributor Author

@nrfconnect/ncs-aurora-doc @nrfconnect/ncs-doc-release @nrfconnect/ncs-dragoon-doc @nrfconnect/ncs-si-bluebagel-doc please review

@NordicBuilder NordicBuilder removed the DNM label Jan 20, 2025
@divipillai
Copy link
Contributor

Isn't a changelog entry required for this PR?

@nordicjm
Copy link
Contributor Author

Isn't a changelog entry required for this PR?

Will be part of a followup PR that applies doc changes

Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for SI Muffin

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 20, 2025

Memory footprint analysis revealed the following potential issues

sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 912202[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 821126[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19283/43)

Removes support for child/parent image from these repos

Signed-off-by: Jamie McCrae <[email protected]>
Removes support for child/parent image

Signed-off-by: Jamie McCrae <[email protected]>
Copy link
Contributor

@MarekPieta MarekPieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from perspective of our apps/samples

@rlubos rlubos merged commit 82d3d26 into nrfconnect:main Jan 20, 2025
10 of 13 checks passed
@nordicjm nordicjm deleted the byebyechildparent branch January 21, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-force-downstream doc-required PR must not be merged without tech writer approval. manifest manifest-matter manifest-mcuboot manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.