Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssf: remove the reset_evt sdfw_update and echo service #19490

Merged
merged 1 commit into from
Jan 23, 2025
Merged

ssf: remove the reset_evt sdfw_update and echo service #19490

merged 1 commit into from
Jan 23, 2025
+2 −1,873

Conversation

hakonfam
Copy link
Contributor

These are not needed

Ref: NCSDK-30980

@hakonfam hakonfam requested review from a team and anhmolt as code owners December 13, 2024 06:01
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 13, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 13, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 14

Inputs:

Sources:

sdk-nrf: PR head: 3271e9c738b71f972faadb2b6152609678740386

more details

sdk-nrf:

PR head: 3271e9c738b71f972faadb2b6152609678740386
merge base: b65f69a952107a821e23c0a222a1d2545db8b437
target head (main): e3026d627317467d31276584ce8bbd9d87096e1d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (54) 
.github
│  │ test-spec.yml
CODEOWNERS
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
│  │  ├── samples.rst
│  │  ├── samples
│  │  │  │ sdfw.rst
include
│  ├── sdfw
│  │  ├── sdfw_services
│  │  │  ├── echo_service.h
│  │  │  ├── reset_evt_service.h
│  │  │  │ sdfw_update_service.h
samples
│  ├── sdfw
│  │  ├── ssf_client
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── README.rst
│  │  │  ├── boards
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpurad.overlay
│  │  │  │  ├── nrf9280pdk_nrf9280_cpuapp.conf
│  │  │  │  ├── nrf9280pdk_nrf9280_cpuapp.overlay
│  │  │  │  ├── nrf9280pdk_nrf9280_cpurad.conf
│  │  │  │  │ nrf9280pdk_nrf9280_cpurad.overlay
│  │  │  ├── prj.conf
│  │  │  ├── sample.yaml
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  │  │ uart_logging.conf
│  ├── suit
│  │  ├── recovery
│  │  │  │ prj.conf
subsys
│  ├── sdfw_services
│  │  ├── services
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── echo
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── echo_service.c
│  │  │  │  ├── echo_service.cddl
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── echo_service_decode.c
│  │  │  │  │  ├── echo_service_decode.h
│  │  │  │  │  ├── echo_service_encode.c
│  │  │  │  │  ├── echo_service_encode.h
│  │  │  │  │  │ echo_service_types.h
│  │  │  ├── reset_evt
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── reset_evt_service.c
│  │  │  │  ├── reset_evt_service.cddl
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── reset_evt_service_decode.c
│  │  │  │  │  ├── reset_evt_service_decode.h
│  │  │  │  │  ├── reset_evt_service_encode.c
│  │  │  │  │  ├── reset_evt_service_encode.h
│  │  │  │  │  │ reset_evt_service_types.h
│  │  │  ├── sdfw_update
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── sdfw_update_service.c
│  │  │  │  ├── sdfw_update_service.cddl
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── sdfw_update_service_decode.c
│  │  │  │  │  ├── sdfw_update_service_decode.h
│  │  │  │  │  ├── sdfw_update_service_encode.c
│  │  │  │  │  ├── sdfw_update_service_encode.h
│  │  │  │  │  │ sdfw_update_service_types.h

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 13
  • ✅ Integration tests
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

jonathannilsen
jonathannilsen reviewed Dec 13, 2024
View reviewed changes
samples/sdfw/ssf_client/src/main.c Outdated
if (IS_ENABLED(CONFIG_ENABLE_RESET_EVT_SUBSCRIBE_REQUEST)) {
reset_evt_subscribe();
}

if (IS_ENABLED(CONFIG_ENABLE_SDFW_UPDATE_REQUEST)) {
sdfw_update();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit strange to keep the sample here when this is disabled by default and so the sample effectively does nothing. Should we remove the sample entirely? Users should not be using this API for updating SDFW anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. If the sample is not changed to do something else with sdfw_services, then it is of no use after removing these services.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only immediate use for this I can see would be for #19278. I still think we can remove sdfw_update here though, and even the whole sdfw_update client

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Another possible suggestion is to invoke ssf_psa_generate_random and get some random values. Given that it is that simple, and no PSA initialization is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the ssf_client sample

anhmolt

This comment was marked as resolved.

Sign in to view

@hakonfam hakonfam force-pushed the remove-reset-evt-service branch from 7204ba4 to 6650334 Compare December 16, 2024 12:36
@hakonfam hakonfam requested review from a team as code owners December 16, 2024 12:36
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 16, 2024
@hakonfam
Copy link
Contributor Author

Listed files echo_service.h and reset_evt_service.h in nrf/.github/test-spec.yml can be removed. Also, are some of the other sdfw services missing from the CI-secdom-test list?

I removed these entries.

@hakonfam hakonfam changed the title ssf: remove the reset_evt and echo service ssf: remove the reset_evt sdfw_update and echo service Dec 16, 2024
jonathannilsen

This comment was marked as resolved.

Sign in to view

@hakonfam hakonfam force-pushed the remove-reset-evt-service branch 2 times, most recently from c9b31a5 to b4b7ce9 Compare December 16, 2024 14:39
@hakonfam hakonfam requested a review from a team as a code owner December 16, 2024 14:39
@hakonfam hakonfam force-pushed the remove-reset-evt-service branch 2 times, most recently from fe54786 to 6ff65af Compare December 19, 2024 05:42
@hakonfam
Copy link
Contributor Author

CI is green on rerun

@umapraseeda
Copy link
Contributor

Missing changelog entry

@hakonfam hakonfam force-pushed the remove-reset-evt-service branch from 6ff65af to e08e6fe Compare December 20, 2024 08:25
@hakonfam hakonfam requested a review from a team as a code owner December 20, 2024 08:25
@hakonfam
Copy link
Contributor Author

Missing changelog entry

Added an entry, please check if I added it to the right place - long time since I did an update to the sdk-nrf changelog.

@hakonfam hakonfam requested a review from peknis January 2, 2025 12:10
@hakonfam hakonfam force-pushed the remove-reset-evt-service branch from e08e6fe to dabc136 Compare January 2, 2025 12:11
@shanthanordic shanthanordic requested review from ChristopherBittner and a team January 9, 2025 06:37
@hakonfam hakonfam force-pushed the remove-reset-evt-service branch from dabc136 to e608880 Compare January 13, 2025 05:16
@hakonfam
Copy link
Contributor Author

@ncs-test-leads and @nrfconnect/ncs-aurora-doc please review - green CI

conflicting files are deleted

@jonathannilsen
Copy link
Contributor

jonathannilsen commented Jan 14, 2025 •
edited
Loading

@ncs-test-leads and @nrfconnect/ncs-aurora-doc please review - green CI

conflicting files are deleted

@nrfconnect/ncs-test-leads *

@hakonfam hakonfam force-pushed the remove-reset-evt-service branch from e608880 to b685092 Compare January 15, 2025 05:29
@hakonfam
ssf: remove reset_evt, sdfw_update and echo service
3271e9c 
These are not needed any more.

Also remove the ssf_client sample since all its services are now
removed.

Ref: NCSDK-30980

Signed-off-by: Håkon Amundsen <[email protected]>
@hakonfam hakonfam force-pushed the remove-reset-evt-service branch from b685092 to 3271e9c Compare January 15, 2025 11:22
@hakonfam hakonfam requested a review from FrancescoSer January 15, 2025 11:22
@hakonfam hakonfam requested a review from FrancescoSer January 20, 2025 09:01
@rlubos rlubos merged commit ba67329 into nrfconnect:main Jan 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peknis peknis peknis approved these changes

@shanthanordic shanthanordic shanthanordic approved these changes

@anhmolt anhmolt anhmolt approved these changes

@FrancescoSer FrancescoSer FrancescoSer approved these changes

@umapraseeda umapraseeda umapraseeda approved these changes

@jonathannilsen jonathannilsen jonathannilsen approved these changes

@nordicjm nordicjm nordicjm approved these changes

@karstenkoenig karstenkoenig karstenkoenig approved these changes

@tomchy tomchy tomchy approved these changes

@ChristopherBittner ChristopherBittner Awaiting requested review from ChristopherBittner

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.