Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Prevent regenerating dfu multi image on every build #19636

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

adigie
Copy link
Member

@adigie adigie commented Dec 19, 2024

  • Move running dfu_multi_image_tool.py out of custom target to stop regenerating the image on every build.
  • Fix DEPENDS for dfu_multi_image_package.

@adigie adigie requested a review from a team as a code owner December 19, 2024 08:04
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 19, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 19, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 9a0127956de01df6a8e488ee050f707f7e2d1894

more details

sdk-nrf:

PR head: 9a0127956de01df6a8e488ee050f707f7e2d1894
merge base: c9251c2c358d8e184999c9ae1d37b5d4a901d53c
target head (main): c9251c2c358d8e184999c9ae1d37b5d4a901d53c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
cmake
│  │ dfu_multi_image.cmake
subsys
│  ├── bootloader
│  │  ├── cmake
│  │  │  │ packaging.cmake

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-sdk-audio
    • ◻️ desktop52_verification
    • ◻️ test-fw-nrfconnect-boot
    • ◻️ test-fw-nrfconnect-apps
    • ◻️ test_ble_nrf_config
    • ◻️ test-fw-nrfconnect-ble_mesh
    • ◻️ test-fw-nrfconnect-ble_samples
    • ◻️ test-fw-nrfconnect-chip
    • ◻️ test-fw-nrfconnect-nfc
    • ◻️ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ◻️ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ◻️ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ◻️ test-fw-nrfconnect-nrf-iot_samples
    • ◻️ test-fw-nrfconnect-nrf-iot_lwm2m
    • ◻️ doc-internal
    • ◻️ test-fw-nrfconnect-nrf-iot_thingy91
    • ◻️ test-fw-nrfconnect-nrf_crypto
    • ◻️ test-fw-nrfconnect-rpc
    • ◻️ test-fw-nrfconnect-rs
    • ◻️ test-fw-nrfconnect-fem
    • ◻️ test-fw-nrfconnect-tfm
    • ◻️ test-fw-nrfconnect-thread
    • ◻️ test-fw-nrfconnect-zigbee
    • ◻️ test-sdk-find-my
    • ◻️ test-fw-nrfconnect-nrf-iot_mosh
    • ◻️ test-fw-nrfconnect-nrf-iot_positioning
    • ◻️ test-sdk-sidewalk
    • ◻️ test-sdk-wifi
    • ◻️ test-low-level
    • ◻️ test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • ◻️ test-sdk-pmic-samples
    • ◻️ test-sdk-mcuboot
    • ◻️ test-sdk-dfu
    • ◻️ test-fw-nrfconnect-ps
    • ◻️ test-secdom-samples-public
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 19, 2024

Memory footprint analysis revealed the following potential issues

sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 911854[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 820682[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19636/4)

@adigie adigie removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 19, 2024
modules/mcuboot/CMakeLists.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 7, 2025
@adigie adigie requested a review from nordicjm January 9, 2025 08:52
* Move running dfu_multi_image_tool.py out of custom target to stop
regenerating the image on every build.
* Fix DEPENDS for dfu_multi_image_package.

Signed-off-by: Adrian Gielniewski <[email protected]>
@adigie
Copy link
Member Author

adigie commented Jan 16, 2025

@nordicjm Could you take a look?

@rlubos rlubos merged commit 371ff9d into nrfconnect:main Jan 17, 2025
12 checks passed
@adigie adigie deleted the fix-dfu-target branch January 17, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants