Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: controller: remove vs supported commands implementation #19789

Conversation

olivier-le-sage
Copy link
Contributor

This command was deprecated a long time ago.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 8, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 8, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 10

Inputs:

Sources:

sdk-nrf: PR head: 25cd78cc314beb9394891d39a37a04c3d5e55dca

more details

sdk-nrf:

PR head: 25cd78cc314beb9394891d39a37a04c3d5e55dca
merge base: 509fa66004370f00faf13912cc6fced25dda6d6c
target head (main): 658662845a8e4d4cb677800c8d36acfac9176c90
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
include
│  ├── bluetooth
│  │  │ hci_vs_sdc.h
subsys
│  ├── bluetooth
│  │  ├── controller
│  │  │  │ hci_internal.c
│  │  │ hci_vs_sdc.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 987
  • ✅ Integration tests
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
    • ✅ test-sdk-sidewalk
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@olivier-le-sage olivier-le-sage force-pushed the remove-vs-supported-commands-implementation branch from 62701fa to e9fe203 Compare January 10, 2025 14:49
@olivier-le-sage olivier-le-sage marked this pull request as ready for review January 13, 2025 07:57
@olivier-le-sage olivier-le-sage requested review from a team as code owners January 13, 2025 07:57
Copy link
Contributor

@rugeGerritsen rugeGerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivier-le-sage , would you mind creating a separate PR to update the code owner file? Then we avoid adding @nrfconnect/ncs-si-muffin every time we update hci_vs_sdc_read_supported_vs_commands.c

subsys/bluetooth/hci_vs_sdc.c Show resolved Hide resolved
This command was deprecated a long time ago.

Signed-off-by: Olivier Lesage <[email protected]>
@olivier-le-sage olivier-le-sage force-pushed the remove-vs-supported-commands-implementation branch from e9fe203 to 25cd78c Compare January 13, 2025 08:07
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@olivier-le-sage
Copy link
Contributor Author

@olivier-le-sage , would you mind creating a separate PR to update the code owner file? Then we avoid adding @nrfconnect/ncs-si-muffin every time we update hci_vs_sdc_read_supported_vs_commands.c

#19860

Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the Muffin point of view

@rlubos rlubos merged commit 33bdc5f into nrfconnect:main Jan 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants