-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: Add required heap to the gatt_dm #19863
Conversation
ed52871
to
220b82c
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 431ec292d6097b5e3d028c9ca780e655d232cfcc more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
220b82c
to
c9d038a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -12,6 +12,7 @@ CONFIG_BT_SMP=y | |||
CONFIG_BT_CENTRAL=y | |||
CONFIG_BT_MAX_CONN=1 | |||
CONFIG_BT_BONDABLE=n | |||
CONFIG_HEAP_MEM_POOL_SIZE=1024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be required as we use this to add heap here https://github.com/nrfconnect/sdk-nrf/blob/main/subsys/bluetooth/services/ras/rreq/Kconfig.ras_rreq#L27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the requirement according to your comment and the discussion. Please have a look
c9d038a
to
392a57d
Compare
392a57d
to
9c6606b
Compare
It seems that ncs-audio are added to a lot of PRs. Could you have a look at why we have been added here? |
@koffes The ncs-audio was added here when the PR looked different and modified audio configs. Now I don't think the review from audio team is needed. |
Add heap requirement to gatt_dm. Make use of HEAP_MEM_POOL_ADD_SIZE_* Kconfig to increase required heap for gatt_dm module. Remove the requirement from ras service, since the requirement is added to gatt_dm itself. Jira: NCSDK-31002 Signed-off-by: Dominik Chat <[email protected]>
9c6606b
to
431ec29
Compare
Add heap requirement to gatt_dm.
Make use of HEAP_MEM_POOL_ADD_SIZE_* Kconfig
to increase required heap for gatt_dm module.
Remove the requirement from ras service, since
the requirement is added to gatt_dm itself.
Jira: NCSDK-31002