Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: Add required heap to the gatt_dm #19863

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

dchat-nordic
Copy link
Contributor

@dchat-nordic dchat-nordic commented Jan 13, 2025

Add heap requirement to gatt_dm.
Make use of HEAP_MEM_POOL_ADD_SIZE_* Kconfig
to increase required heap for gatt_dm module.

Remove the requirement from ras service, since
the requirement is added to gatt_dm itself.

Jira: NCSDK-31002

@dchat-nordic dchat-nordic requested a review from a team as a code owner January 13, 2025 10:14
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 13, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 13, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 431ec292d6097b5e3d028c9ca780e655d232cfcc

more details

sdk-nrf:

PR head: 431ec292d6097b5e3d028c9ca780e655d232cfcc
merge base: d899e22404f40e028cc7c1cbf71930e06e321cd3
target head (main): d5cd914eae77e7ccbb2cdc533e35267a42fb068f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
subsys
│  ├── bluetooth
│  │  ├── Kconfig.discovery
│  │  ├── services
│  │  │  ├── ras
│  │  │  │  ├── rreq
│  │  │  │  │  │ Kconfig.ras_rreq

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 6
  • ✅ Integration tests
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • doc-internal
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -12,6 +12,7 @@ CONFIG_BT_SMP=y
CONFIG_BT_CENTRAL=y
CONFIG_BT_MAX_CONN=1
CONFIG_BT_BONDABLE=n
CONFIG_HEAP_MEM_POOL_SIZE=1024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the requirement according to your comment and the discussion. Please have a look

@koffes
Copy link
Contributor

koffes commented Jan 15, 2025

It seems that ncs-audio are added to a lot of PRs. Could you have a look at why we have been added here?

@dchat-nordic
Copy link
Contributor Author

@koffes The ncs-audio was added here when the PR looked different and modified audio configs. Now I don't think the review from audio team is needed.

Add heap requirement to gatt_dm.
Make use of HEAP_MEM_POOL_ADD_SIZE_* Kconfig
to increase required heap for gatt_dm module.

Remove the requirement from ras service, since
the requirement is added to gatt_dm itself.

Jira: NCSDK-31002

Signed-off-by: Dominik Chat <[email protected]>
@dchat-nordic dchat-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 16, 2025
@rlubos rlubos merged commit 11284f3 into nrfconnect:main Jan 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants