[Backport v2.9-nRF54H20-branch] tests: benchmarks: power_consumption: i2c: Fix increased power consumpion #19881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test was suspending test thread from the timer interrupt at random (but periodic) point. Some drivers which are tested in that framework handles power management in the thread context. Randomly suspending the test thread could lead to a case where driver did not finish requested operation and system goes to s2ram in the middle of the driver operation. Extending the test framework to allow more controlled thread suspension. Timer can indicate to the thread that is shall be suspended and thread calls self suspension when ready. Signed-off-by: Krzysztof Chruściński <[email protected]> (cherry picked from commit 6f4dc17)
Test thread cannot be suspended at any time because driver power management happens in the thread context so if thread is suspended at the random moment and system goes to s2ram it can lead to increased power consumption because thread got suspended before i2c device got properly suspended. Signed-off-by: Krzysztof Chruściński <[email protected]> (cherry picked from commit 4408403)
Add property to enable runtime PM for i2c and spi used for controlling the sensor. Signed-off-by: Krzysztof Chruściński <[email protected]> (cherry picked from commit 6dd7041)
github-actions
bot
added
the
changelog-entry-required
nordic-pikr
approved these changes
Jan 13, 2025
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: e0df6cbbf191ada33252e857c29dae5bc829a326 more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: 11349092be Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
nordic-piks
approved these changes
Jan 13, 2025
nordic-bami
approved these changes
Jan 14, 2025
nordic-segl
approved these changes
Jan 14, 2025
nordicjm
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6dd7041~3..6dd7041 from #19861.