Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt: fmfu: Hide MGMT_FMFU logging options when not enabled #19951

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rugeGerritsen
Copy link
Contributor

When building an application we don't want
CONFIG_MGMT_FMFU_LOG_LEVEL_DEFAULT to turn up in the generated .config file unless CONFIG_MGMT_FMFU is enabled.

@rugeGerritsen rugeGerritsen requested a review from a team as a code owner January 16, 2025 13:13
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 16, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 16, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: fec7cdbf71d461f0487832da0ccbbe6005fb2b4f

more details

sdk-nrf:

PR head: fec7cdbf71d461f0487832da0ccbbe6005fb2b4f
merge base: 8b83cf2b4d708062e566d84e2969e4225b307331
target head (main): fcbe2bb36580697a2fecbbe907917bee9646bbaa
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
subsys
│  ├── mgmt
│  │  ├── fmfu
│  │  │  │ Kconfig

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 260
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-sdk-mcuboot
    • ⚠️ test-fw-nrfconnect-fw-update
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@rugeGerritsen rugeGerritsen requested a review from a team January 16, 2025 13:32
subsys/mgmt/fmfu/Kconfig Outdated Show resolved Hide resolved
When building an application we don't want
CONFIG_MGMT_FMFU_LOG_LEVEL_DEFAULT to turn up in the generated
.config file unless CONFIG_MGMT_FMFU is enabled.

Signed-off-by: Rubin Gerritsen <[email protected]>
@rugeGerritsen
Copy link
Contributor Author

@nrfconnect/ncs-pluto , would you mind having a look at this one?

@nordicjm
Copy link
Contributor

@nrfconnect/ncs-pluto , would you mind having a look at this one?

already did

@rugeGerritsen
Copy link
Contributor Author

@nrfconnect/ncs-pluto , would you mind having a look at this one?

already did

Need one more approver :)

@rugeGerritsen
Copy link
Contributor Author

@nrfconnect/ncs-pluto , would you mind having a look at this one?

already did

Need one more approver :)

@nrfconnect/ncs-pluto would you mind having a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants