Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Mesh: Fix idx in dtt_srv_get #19984

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

HaavardRei
Copy link
Contributor

Finds the element index used in bt_mesh_dtt_srv_get based on the composition data instead of the runtime address.

Previously, the index used to locate the DTT Server was computed based on the runtime address set during provisioning. As the Scene Setup Server extends this model (which isn't necessarily present in the same element), model initialization would fail as the address wasn't yet set.

Finds the element index used in `bt_mesh_dtt_srv_get` based on the
composition data instead of the runtime address.

Previously, the index used to locate the DTT Server was computed based
on the runtime address set during provisioning. As the Scene Setup
Server extends this model (which isn't necessarily present in the same
element), model initialization would fail as the address wasn't yet set.

Signed-off-by: Håvard Reierstad <[email protected]>
@HaavardRei HaavardRei requested a review from a team as a code owner January 20, 2025 10:05
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. labels Jan 20, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 20, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 8e0d8f211c30f47d8a640182ce876b178d4db4ae

more details

sdk-nrf:

PR head: 8e0d8f211c30f47d8a640182ce876b178d4db4ae
merge base: 32dc027186039919359dd39dbb3f5434088ea107
target head (main): 32dc027186039919359dd39dbb3f5434088ea107
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
subsys
│  ├── bluetooth
│  │  ├── mesh
│  │  │  │ gen_dtt_srv.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 820
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_mesh
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@nordicjm nordicjm merged commit d946273 into nrfconnect:main Jan 21, 2025
13 checks passed
@HaavardRei HaavardRei deleted the mesh_dtt_srv_idx branch January 21, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants