Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: sdp: no copy IPC #20116

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

applications: sdp: no copy IPC #20116

wants to merge 7 commits into from

Conversation

mif1-nordic
Copy link
Contributor

Depends on #20017

@mif1-nordic mif1-nordic requested review from a team as code owners January 29, 2025 14:43
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 29, 2025
@masz-nordic masz-nordic changed the title No copy ipc applications: sdp: no copy IPC Jan 29, 2025
@masz-nordic masz-nordic added this to the 3.0.0 milestone Jan 29, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 29, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 5d6c142489e8671a0bb1fbf52a56f040d44da7c3

more details

sdk-nrf:

PR head: 5d6c142489e8671a0bb1fbf52a56f040d44da7c3
merge base: 10e197ecd2b3c9cd4c58565efa35e1b71061d0fb
target head (main): 571676740aacb35db0cc99ee67a5598820ed1c59
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6) 
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt.c
│  │  │  │  │  ├── hrt.h
│  │  │  │  │  │ hrt.s
│  │  │  │  │ main.c
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c
include
│  ├── drivers
│  │  ├── mspi
│  │  │  │ nrfe_mspi.h

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 24
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@mif1-nordic mif1-nordic force-pushed the no_copy_ipc branch 6 times, most recently from 65d0007 to bdeae8e Compare January 30, 2025 10:49
@mif1-nordic
drivers: mspi: Reduced IPC structures-drivers
cdd1c39 
Implemented smaller structures and reduced ammount of opcodes in IPC

Signed-off-by: Michal Frankiewicz <[email protected]>
@mif1-nordic
applications: sdp: mspi: Reduced IPC structures-applications
a0ba939 
Implemented smaller structures and reduced ammount of opcodes in IPC

Signed-off-by: Michal Frankiewicz <[email protected]>
@mif1-nordic
applications: sdp: mspi: Dummy cycles fix
552cec2 
Fixed dummy cycles implementation.
Changed dummy cycles limit from 32 to UINT32_MAX.

Signed-off-by: Michal Frankiewicz <[email protected]>
@mif1-nordic
applications: sdp: mspi: Fixed bit blocking on bus width change
fd599fe 
Fixed bug where after increasing bus width using buffered registers,
in first clock cycle the mask for previous bus width was still present.

Signed-off-by: Michal Frankiewicz <[email protected]>
@mif1-nordic
applications: sdp: mspi: Fixed additional clock edge in modes 1-3
1b63df7 
Added workarounds to hardware issue causing,
additional clock edge in spi modes 1-3.

Signed-off-by: Michal Frankiewicz <[email protected]>
@mif1-nordic
drivers: mspi: No copy IPC-drivers
bccb9ee 
Implemented option to pass data between cores
through IPC by reference.

Signed-off-by: Michal Frankiewicz <[email protected]>
@mif1-nordic
applications: sdp: mspi: No copy IPC-applications
5d6c142 
Implemented option to pass data between cores
through IPC by reference.

Signed-off-by: Michal Frankiewicz <[email protected]>
jaz1-nordic
jaz1-nordic reviewed Jan 30, 2025
View reviewed changes
include/drivers/mspi/nrfe_mspi.h
@@ -16,6 +16,8 @@ extern "C" {

#ifdef CONFIG_SOC_NRF54L15

#define NRFE_MSPI_NO_COPY_IPC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an option in Kconfig, set to default value depending on the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaz1-nordic jaz1-nordic jaz1-nordic left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mif1-nordic @NordicBuilder @jaz1-nordic @masz-nordic