Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nRF54 minor improvements #533

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Apr 8, 2024

CI parameters

(branch, hash, pull/XXX/head)
NRF_revision=main

(true, false)
Create_NRF_PR=false

Description

JIRA ticket:

KRKNWK-18680

Self review

  • There is no commented code.
  • There is no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized
  • Verification
    • Unit tests were updated to include the change.
    • Change has been tested.

@github-actions github-actions bot added source PR changing src files tests labels Apr 8, 2024
[KRKNWK-18680]
warning: NRF_RTC_TIMER_USER_CHAN_COUNT
was assigned the value '0' but got the value ''.

Signed-off-by: Krzysztof Taborowski <[email protected]>
CMake Error at CMakeLists.txt:18 (get_filename_component)

Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18680]
nrf54L15 cos support is experimental

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski force-pushed the nrf54-minor-improvements branch from 8a2644f to c129326 Compare April 8, 2024 14:26
Copy link

github-actions bot commented Apr 8, 2024

Sample diff used total
nrf52840dk_nrf52840:sample.sidewalk.hello.no_dfu RAM 0 B 96.29 KB 256 KB
ROM 80 B 477.38 KB 983.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.hello.no_dfu RAM 0 B 84.95 KB 440 KB
ROM 96 B 414.93 KB 975.5 KB

@ktaborowski ktaborowski merged commit 47cf235 into nrfconnect:main Apr 9, 2024
56 checks passed
@ktaborowski ktaborowski deleted the nrf54-minor-improvements branch April 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
func-commit source PR changing src files tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants