Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use nrfutil in documentation #640

Merged
merged 3 commits into from
Nov 5, 2024
Merged

doc: use nrfutil in documentation #640

merged 3 commits into from
Nov 5, 2024

Conversation

RobertGalatNordic
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic commented Nov 4, 2024 •
edited
Loading

KRKNWK-19513
nrf54 should use nrfutil for flashing

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. source PR changing src files labels Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Sample diff used total
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 106.31 KB 0 B
ROM 4 B 351.3 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 0 B 112.98 KB 0 B
ROM 4 B 410.63 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 86.64 KB 0 B
ROM 4 B 310.41 KB 0 B

@RobertGalatNordic RobertGalatNordic marked this pull request as ready for review November 4, 2024 15:34
ktaborowski
ktaborowski approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ktaborowski ktaborowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-19513_nrf54l15_release_documentation_review branch from 10cee31 to 38909c2 Compare November 5, 2024 08:56
totyz
totyz approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-19513_nrf54l15_release_documentation_review branch 2 times, most recently from fa7241e to 650e9a2 Compare November 5, 2024 09:43
@totyz totyz removed the source PR changing src files label Nov 5, 2024
@RobertGalatNordic
doc: use nrfutil in documentation
ef850dd 
KRKNWK-19513
nrf54 should use nrfutil for flashing

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic
doc: update expected logs on boot
34ac319 
KRKNWK-19513
boot message changed since last release

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic
doc: update memory requirements
ce02523 
KRKNWK-19513
used values from latest known main:
test-sdk-sidewalk/job/master/1306/

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-19513_nrf54l15_release_documentation_review branch from 650e9a2 to ce02523 Compare November 5, 2024 14:12
@github-actions github-actions bot added the source PR changing src files label Nov 5, 2024
@RobertGalatNordic RobertGalatNordic merged commit b27c0fb into nrfconnect:main Nov 5, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annwoj annwoj annwoj approved these changes

@totyz totyz totyz approved these changes

@ktaborowski ktaborowski ktaborowski approved these changes

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. source PR changing src files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobertGalatNordic @ktaborowski @totyz @annwoj