Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: refactor tests #649

Merged
merged 3 commits into from
Dec 20, 2024
Merged

tests: refactor tests #649

merged 3 commits into from
Dec 20, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Nov 29, 2024 •
edited
Loading

KRKNWK-14886
Move and refactor tests:

  • critical_region
  • crypto
  • crypto_keys
  • delay
  • interrupts
  • mfg not working
  • spi
  • storage
  • temperature
  • time

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added source PR changing src files tests labels Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

Sample diff used total
nrf52840dk/nrf52840:sample.sidewalk.demo RAM -104 B 123.64 KB 0 B
ROM -60 B 478.77 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM -104 B 108.3 KB 0 B
ROM -60 B 396.28 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM -104 B 147.28 KB 0 B
ROM -60 B 544.74 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.ble_only RAM -104 B 131.88 KB 0 B
ROM -60 B 461.63 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo RAM -80 B 121.57 KB 0 B
ROM -68 B 456.1 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM -80 B 106.52 KB 0 B
ROM -68 B 378.34 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut RAM -80 B 145.32 KB 0 B
ROM -68 B 522.56 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM -80 B 130.21 KB 0 B
ROM -68 B 444.27 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM -80 B 121.57 KB 0 B
ROM -68 B 456.12 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM -80 B 106.52 KB 0 B
ROM -68 B 378.37 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM -80 B 145.32 KB 0 B
ROM -68 B 522.59 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM -80 B 130.21 KB 0 B
ROM -68 B 444.31 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM -80 B 120.79 KB 0 B
ROM -68 B 406.26 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only RAM -80 B 105.74 KB 0 B
ROM -68 B 328.52 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM -80 B 144.54 KB 0 B
ROM -68 B 472.97 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.ble_only RAM -80 B 129.44 KB 0 B
ROM -68 B 394.68 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM -104 B 147.26 KB 0 B
ROM -60 B 536.19 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM -104 B 124.87 KB 0 B
ROM -60 B 494.07 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM -104 B 98.12 KB 0 B
ROM -60 B 394.62 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.no_secure RAM -80 B 145.3 KB 0 B
ROM -68 B 514.87 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM -80 B 123.01 KB 0 B
ROM -68 B 471.38 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM -80 B 96.57 KB 0 B
ROM -68 B 376.64 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM -80 B 145.3 KB 0 B
ROM -68 B 514.9 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM -80 B 123.01 KB 0 B
ROM -68 B 471.42 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM -80 B 96.57 KB 0 B
ROM -68 B 376.67 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure RAM -80 B 144.54 KB 0 B
ROM -68 B 470.27 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello RAM -80 B 122.24 KB 0 B
ROM -68 B 421.56 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only RAM -80 B 95.79 KB 0 B
ROM -68 B 326.81 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM -104 B 93.31 KB 0 B
ROM -68 B 325.23 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM -104 B 108.67 KB 0 B
ROM -68 B 404.21 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only.release RAM -80 B 91.93 KB 0 B
ROM -76 B 305.2 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.release RAM -80 B 106.99 KB 0 B
ROM -76 B 381.08 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM -80 B 91.93 KB 0 B
ROM -76 B 305.23 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM -80 B 106.99 KB 0 B
ROM -76 B 381.11 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release RAM -80 B 91.16 KB 0 B
ROM -76 B 256.32 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release RAM -80 B 106.21 KB 0 B
ROM -76 B 332.19 KB 0 B

@ktaborowski ktaborowski force-pushed the tests_new branch 2 times, most recently from b45a9c4 to 9c04745 Compare December 2, 2024 15:40
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Dec 2, 2024
@ktaborowski ktaborowski force-pushed the tests_new branch 2 times, most recently from b9d68f7 to ddcf163 Compare December 9, 2024 09:12
@ktaborowski ktaborowski force-pushed the tests_new branch 3 times, most recently from 1906f7c to 28e2d02 Compare December 16, 2024 08:46
@ktaborowski ktaborowski marked this pull request as ready for review December 16, 2024 08:56
RobertGalatNordic
RobertGalatNordic requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crypto
mfg
spi
storage

Require rewriting or major refactoring. Please move them to their old location, as they will be addressed in separate PRs.

If some test does not pass, please skip it and place it back in its old location (move to tests_new, only refactored/approved and working tests)

tests_new/integration/time/src/main.c Outdated Show resolved Hide resolved
tests_new/integration/storage/boards/nrf54l15dk_nrf54l15_cpuapp_ns.overlay Outdated Show resolved Hide resolved
tests_new/integration/storage/src/main.c Outdated Show resolved Hide resolved
tests_new/integration/spi/src/main.c Outdated Show resolved Hide resolved
tests_new/integration/mfg/src/main.c Show resolved Hide resolved
tests_new/integration/crypto/src/main.c Outdated Show resolved Hide resolved
tests_new/integration/crypto_keys/src/main.c Show resolved Hide resolved
tests_new/integration/delay/src/main.c Show resolved Hide resolved
tests_new/integration/interrupts/src/main.c Show resolved Hide resolved
tests_new/integration/mfg/testcase.yaml Outdated Show resolved Hide resolved
@ktaborowski ktaborowski force-pushed the tests_new branch 4 times, most recently from 12d837c to e96bbfa Compare December 19, 2024 15:25
@ktaborowski
tests: refactor tests
8783621 
[KRKNWK-14886]

* Move critical_region test to new location
* Move crypto keys test to new location
* Move crypto test to new location
* Move delay test to new location
* Move interrupts test to new location
* Move spi test to new location
* Move storage test to new location
* Move temperature test to new location
* Move time test to new location

* Add native_sim board support (not all)
* Port to ztest
* Remove sanity tests

Signed-off-by: Krzysztof Taborowski <[email protected]>

tests: move mfg storage test

Tests skipped - to be rewritten

Signed-off-by: Krzysztof Taborowski <[email protected]>

tests: temperature tests on simulator board

Use mock temperature pal when no temp sensor in dts

Signed-off-by: Krzysztof Taborowski <[email protected]>

tests: review

to be squashed

Signed-off-by: Krzysztof Taborowski <[email protected]>

tests: fix tests

to be sqashed

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
tests: skip mfg tests
a9d903f 
Skip mfg tests for now.
Relace existing tests with simple read write test.

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
tests: remove nrf52 from spi
14dfd8f 
nrfx spi doesn't pass the tests

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski merged commit a45a3c9 into nrfconnect:main Dec 20, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktaborowski @RobertGalatNordic