cmake: removing manual linking of libgcc.a #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sid-lib
nordicjm
approved these changes
Dec 4, 2024
carlescufi
approved these changes
Dec 4, 2024
|
Similar code for M 4 (nrf52) libraries: sidewalk/lib/cortex-m4/lora_fsk/CMakeLists.txt |
|
nice catch. |
ktaborowski
approved these changes
Dec 4, 2024
This commit removes the manual lookup and linking of libgcc.a. Linking of C and runtime libraries are the responsibility of the higher level build system which handles the toolchain and building of the executable. Current sidewalk implementation is broken in the sense that it fails to consider the CPU architecture and just looks up any libgcc.a file. For example the code might discover `arm-zephyr-eabi/12.2.0/libgcc.a` when instead `arm-zephyr-eabi/12.2.0/thumb/v8-m.main+fp/hard/libgcc.a` should be used, and thus causiong link errors such as: > error: /.../12.2.0/libgcc.a(_arm_muldf3.o): > conflicting CPU architectures 17/2 and: > error: zephyr/zephyr_pre0.elf uses VFP register arguments, > /.../12.2.0/libgcc.a(_fixunsdfdi.o) does not Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
issues/libgcc_linking
branch
from
b713b97 to
e420702
Compare
done |
|
@tejlmand @ktaborowski please apply this change to the |
there is already a PR for that here: #654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the manual lookup and linking of libgcc.a.
Linking of C and runtime libraries are the responsibility of the higher level build system which handles the toolchain and building of the executable.
Current sidewalk implementation is broken in the sense that it fails to consider the CPU architecture and just looks up any libgcc.a file.
For example the code might discover
arm-zephyr-eabi/12.2.0/libgcc.awhen insteadarm-zephyr-eabi/12.2.0/thumb/v8-m.main+fp/hard/libgcc.ashould be used, and thus causiong link errors such as:and: