Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: port assert test to zephyr unit tests #655

Merged
merged 1 commit into from
Dec 6, 2024
Merged

tests: port assert test to zephyr unit tests #655

merged 1 commit into from
Dec 6, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Dec 4, 2024 •
edited by totyz
Loading

Assert tests to use zephyr unit testing framework. It fixes false negative result when the posix board was used.

Port to v2.8 branch to unblock testing

Same changes as #650

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: v2.8-branch

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: v2.8-branch

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@ktaborowski
tests: port assert test to zephyr unit tests
9a7b44f 
Assert tests to use zephyr unit testing framework.
It fixes false negative result when the posix board was used.

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski requested a review from totyz December 4, 2024 12:49
@github-actions github-actions bot added source PR changing src files tests labels Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Sample diff used total
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only RAM -4.3 KB 101.53 KB 0 B
ROM -10.95 KB 317.53 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM -4.57 KB 140.05 KB 0 B
ROM -11.93 KB 460.99 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.ble_only RAM -129.51 KB 0 B 0 B
ROM -394.63 KB 0 B 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure RAM -4.57 KB 140.05 KB 0 B
ROM -11.93 KB 458.29 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello RAM -4.57 KB 117.75 KB 0 B
ROM -11.32 KB 410.2 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only RAM -4.3 KB 91.57 KB 0 B
ROM -10.91 KB 315.87 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release RAM -4.3 KB 86.94 KB 0 B
ROM -8.78 KB 247.51 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release RAM -4.57 KB 101.72 KB 0 B
ROM -8.83 KB 323.33 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM -4.57 KB 117.08 KB 0 B
ROM -11.05 KB 445.19 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM -4.3 KB 102.3 KB 0 B
ROM -10.93 KB 367.55 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM -4.57 KB 140.83 KB 0 B
ROM -11.93 KB 510.77 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM -130.29 KB 0 B 0 B
ROM -444.41 KB 0 B 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM -4.57 KB 140.82 KB 0 B
ROM -11.92 KB 503.09 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM -4.57 KB 118.53 KB 0 B
ROM -11.33 KB 460.2 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM -4.3 KB 92.35 KB 0 B
ROM -10.91 KB 365.87 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM -4.3 KB 87.71 KB 0 B
ROM -8.79 KB 296.57 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM -4.57 KB 102.5 KB 0 B
ROM -8.82 KB 372.41 KB 0 B
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM -3.1 KB 106.34 KB 0 B
ROM -6.07 KB 351.69 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo RAM -5.74 KB 118 KB 0 B
ROM -28.27 KB 450.53 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM -5.47 KB 102.93 KB 0 B
ROM -28.14 KB 368.16 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM -5.74 KB 141.65 KB 0 B
ROM -29.14 KB 515.62 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.ble_only RAM -131.98 KB 0 B 0 B
ROM -461.65 KB 0 B 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM -5.74 KB 141.62 KB 0 B
ROM -29.13 KB 507.08 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM -5.74 KB 119.23 KB 0 B
ROM -28.54 KB 465.56 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM -5.47 KB 92.76 KB 0 B
ROM -28.14 KB 366.51 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM -5.47 KB 87.95 KB 0 B
ROM -26.03 KB 299.24 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM -5.74 KB 103.03 KB 0 B
ROM -26.06 KB 378.18 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM -3.37 KB 111.5 KB 0 B
ROM -6.18 KB 395.55 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM -3.1 KB 96.58 KB 0 B
ROM -6.08 KB 312.05 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM -3.37 KB 135.27 KB 0 B
ROM -7.05 KB 461.38 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.ble_only RAM -123.4 KB 0 B 0 B
ROM -384.36 KB 0 B 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure RAM -3.37 KB 135.25 KB 0 B
ROM -7.07 KB 453.93 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM -3.37 KB 113 KB 0 B
ROM -6.45 KB 410.85 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM -3.1 KB 86.66 KB 0 B
ROM -6.06 KB 310.63 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM -3.1 KB 82.02 KB 0 B
ROM -3.92 KB 241.08 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM -3.37 KB 96.94 KB 0 B
ROM -3.96 KB 320.82 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo RAM -121.65 KB 0 B 0 B
ROM -456.17 KB 0 B 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM -106.6 KB 0 B 0 B
ROM -378.42 KB 0 B 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut RAM -145.4 KB 0 B 0 B
ROM -522.63 KB 0 B 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM -130.29 KB 0 B 0 B
ROM -444.34 KB 0 B 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.no_secure RAM -145.38 KB 0 B 0 B
ROM -514.94 KB 0 B 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM -123.09 KB 0 B 0 B
ROM -471.46 KB 0 B 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM -96.64 KB 0 B 0 B
ROM -376.71 KB 0 B 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only.release RAM -92.01 KB 0 B 0 B
ROM -305.29 KB 0 B 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.release RAM -107.07 KB 0 B 0 B
ROM -381.16 KB 0 B 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM -4.57 KB 116.3 KB 0 B
ROM -11.03 KB 395.19 KB 0 B

@ktaborowski ktaborowski merged commit 115325c into nrfconnect:v2.8-branch Dec 6, 2024
56 checks passed
@ktaborowski ktaborowski deleted the fix_test branch December 13, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totyz totyz totyz approved these changes

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@wojciechpluszynski wojciechpluszynski Awaiting requested review from wojciechpluszynski

Assignees
No one assigned
Labels
func-integration source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktaborowski @RobertGalatNordic @totyz