Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: use native YAML lists #669

Merged
merged 2 commits into from
Jan 10, 2025
Merged

samples: use native YAML lists #669

merged 2 commits into from
Jan 10, 2025

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented Jan 2, 2025 •
edited by RobertGalatNordic
Loading

Space-based list support has been removed from upstream Zephyr.

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  #NRF_revision: pull/19726/head
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: true
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Jan 2, 2025
@NordicBuilder NordicBuilder mentioned this pull request Jan 2, 2025
Open
@gmarull gmarull force-pushed the twister-no-space-lists branch from 57c13c0 to 35f2470 Compare January 2, 2025 12:34
@gmarull gmarull requested review from RobertGalatNordic and totyz and removed request for RobertGalatNordic January 2, 2025 13:33
@ktaborowski ktaborowski added the from-nrf align sidewalk with ncs label Jan 7, 2025
@RobertGalatNordic
GHA: fix on_docker_change
ec7aab1 
add path to trigger
fix typo

Signed-off-by: Robert Gałat <[email protected]>
@github-actions GitHub Actions
Copy link

Sample diff used total

Memory usage did not change for any of the samples.

@gmarull @RobertGalatNordic
samples: use native YAML lists
c780d28 
Space-based list support has been removed from upstream Zephyr.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@RobertGalatNordic RobertGalatNordic merged commit c1fe9d2 into nrfconnect:main Jan 10, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

@totyz totyz Awaiting requested review from totyz

@ktaborowski ktaborowski Awaiting requested review from ktaborowski

@annwoj annwoj Awaiting requested review from annwoj

Assignees
No one assigned
Labels
from-nrf align sidewalk with ncs source PR changing src files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmarull @RobertGalatNordic @ktaborowski