Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing the release of v0.13.0 #931

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Preparing the release of v0.13.0 #931

merged 4 commits into from
Jan 29, 2025

Conversation

betolink
Copy link
Member

@betolink betolink commented Jan 28, 2025 •
edited
Loading

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--931.org.readthedocs.build/en/931/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

Binder 👈 Launch a binder notebook on this branch for commit 3b3d130

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 856fab3

Binder 👈 Launch a binder notebook on this branch for commit 8762fa5

Binder 👈 Launch a binder notebook on this branch for commit 79a35fb

@betolink betolink marked this pull request as ready for review January 28, 2025 21:26
@betolink
Copy link
Member Author

Once this PR gets merged we can start the actual tagging and Github release.

@betolink betolink requested a review from jhkennedy January 28, 2025 21:29
mfisher87
mfisher87 reviewed Jan 28, 2025
View reviewed changes
CHANGELOG.md Outdated
## [v0.13.0] - 2025-01-28

### Changed
- Code of conduct: "per NASA direction received on 1/22/2025, per Executive Order on 1/20/2025" [see more](https://en.wikipedia.org/wiki/Nineteen_Eighty-Four)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I like this, I think we shouldn't mention it because (1) risk of impact to our community if someone decides to punish us for this speech; (2) it has no impact on an end-user who installs the software with pip or conda.

The changelog isn't for contributor-facing stuff, or it gets too noisy and confusing for end-users.

mfisher87
mfisher87 requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@mfisher87 mfisher87 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run bumpversion to update CITATION.cff and maybe other files? EDIT: Woops I'm a bad reader. Ignore the comment about bumpversion

CHANGELOG.md
- Integration tests: Test are no longer randomized! this means each fail should be reproducible, we are testing the most
popular datasets from all DAACs, see files under tests/integration/popular_collections.
([#215](https://github.com/nsidc/earthaccess/issues/215))
([**@mfisher87**](https://github.com/mfisher87))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also contributor-facing

@mfisher87
Copy link
Collaborator

pre-commit.ci autofix

@betolink
Copy link
Member Author

Need to run bumpversion to update CITATION.cff and maybe other files? EDIT: Woops I'm a bad reader. Ignore the comment about bumpversion

now that there are many more contributors, should they be included in the citation file?

@betolink betolink merged commit 762c2a2 into nsidc:main Jan 29, 2025
7 of 8 checks passed
@mfisher87 mfisher87 mentioned this pull request Jan 29, 2025
Open
@mfisher87
Copy link
Collaborator

Great call! #932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfisher87 mfisher87 mfisher87 requested changes

@itcarroll itcarroll Awaiting requested review from itcarroll

@ayushnag ayushnag Awaiting requested review from ayushnag

@jhkennedy jhkennedy Awaiting requested review from jhkennedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betolink @mfisher87