rpc/nns: support NEP-18 addresses #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
previously approved these changes
Mar 13, 2024
cthulhu-rider
previously approved these changes
Mar 14, 2024
There was a problem hiding this comment.
code ok
@roman-khimov describe motivation in the commit pls
|
Let's wait for neo-project/proposals#133 to finally settle, but standards are good because they're standards, any compliant tooling can handle the data then. |
carpawell
previously approved these changes
Mar 22, 2024
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
dismissed stale reviews from carpawell, cthulhu-rider, and AnnaShaleva
via
c1fb05d
roman-khimov
force-pushed
the
nep-18-addresses
branch
from
067eb50 to
c1fb05d
Compare
|
Rebased to fix the conflict and it can be merged now, NEP-18 is official. |
|
Test failure is subject to #402, this one doesn't touch contracts. |
AnnaShaleva
approved these changes
Jun 18, 2024
cthulhu-rider
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.