Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metabase migration for SearchV2 #3125

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Metabase migration for SearchV2 #3125

merged 1 commit into from
Feb 18, 2025
+323 −1

Conversation

cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Feb 12, 2025 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 23.03%. Comparing base (db20429) to head (bd36f5b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/local_object_storage/metabase/version.go 41.46% 16 Missing and 8 partials ⚠️
pkg/local_object_storage/metabase/metadata.go 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
+ Coverage   23.00%   23.03%   +0.03%     
==========================================
  Files         756      756              
  Lines       60142    60202      +60     
==========================================
+ Hits        13836    13870      +34     
- Misses      45318    45335      +17     
- Partials      988      997       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthulhu-rider cthulhu-rider force-pushed the object-searchv2/migrationm branch 4 times, most recently from 0e69b60 to c6be0cc Compare February 13, 2025 17:19
@cthulhu-rider cthulhu-rider marked this pull request as ready for review February 13, 2025 17:21
carpawell
carpawell approved these changes Feb 14, 2025
View reviewed changes
pkg/local_object_storage/metabase/version.go Outdated Show resolved Hide resolved
pkg/local_object_storage/metabase/version.go Show resolved Hide resolved
@cthulhu-rider cthulhu-rider force-pushed the object-searchv2/migrationm branch 2 times, most recently from 9670ccd to fe52dc5 Compare February 18, 2025 14:49
@cthulhu-rider cthulhu-rider force-pushed the object-searchv2/migrationm branch from fe52dc5 to bd36f5b Compare February 18, 2025 14:54
roman-khimov
roman-khimov approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct. But what's gonna happen with 1-2M of objects is an open question to me. But we can try with any DB from metis, if it doesn't take a day to complete then ok.

@roman-khimov roman-khimov merged commit d0284a0 into master Feb 18, 2025
19 of 22 checks passed
@roman-khimov roman-khimov deleted the object-searchv2/migrationm branch February 18, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cthulhu-rider @roman-khimov @carpawell