Various fixes mostly for the mobile version #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vogtinator
force-pushed
the
androidwa
branch
2 times, most recently
from
436623a to
b1d2b49
Compare
This can fail for some reason if the Uri is not persistable, possibly caused by Qt not passing FLAG_GRANT_PERSISTABLE_URI_PERMISSION.
That's necessary for style extraction to work.
That way it can be reached with keyboard navigation. It also makes the TextField no longer the first item on the ConfigKits page, which triggered the virtual keyboard to appear each time it was opened.
When sending a file, the thottle timer is disabled automatically. It was only automatically disabled again if the transfer succeeded.
Otherwise it would receive all the signals it connects to multiple times.
That way it's easier to separate the output and the command history is also visible.
For some reason, items within a layout can just grow beyond the size of the layout. Limit them to stay within the parent's region.
This was apparently missed when porting away from designated initializers. It led to random transmission failures.
Apparently Android checks for equivalence of the passed URLs at a string level when looking up URI grants. It has to be fully encoded to match properly. Fixes nspire-emus#202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixture of all kinds of changes.
See the individual commits for details.
The debug page needs aMoved to Various WIP improvements for Mobile #258ScrollViewnow. Unforunately that's a bit glitchy on desktop, jumping at the ends.