ansible-lint

nsv777 · Jul 29, 2023 · 85b3840 · 85b3840
1 parent 3fa5e02
commit 85b3840
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 22 deletions.
diff --git a/playbooks/roles/cinnamon/tasks/main.yml b/playbooks/roles/cinnamon/tasks/main.yml
@@ -1,5 +1,6 @@
 ---
-- ansible.builtin.include_tasks:
+- name: Install Cinnamon on Arch
+  ansible.builtin.include_tasks:
     file: do_install_cinnamon.yml
   when: arch in ansible_distribution
   tags:
@@ -55,6 +56,7 @@
   ansible.builtin.copy:
     src: cinnamon_configs/
     dest: $HOME/.cinnamon/configs/
+    mode: "0644"
   tags:
     - configure
     - cinnamon
diff --git a/playbooks/roles/configure_pacman/tasks/main.yml b/playbooks/roles/configure_pacman/tasks/main.yml
@@ -12,25 +12,25 @@
     - config
 
 
-#- name: pacman.conf
-#  ansible.builtin.lineinfile:
-#    path: /etc/pacman.conf
-#    regexp: "{{ item.regexp }}"
-#    line: "{{ item.line }}"
-#  with_items: lines
-#  vars:
-#    lines:
-#      - regexp: '^#CleanMethod = KeepInstalled$'
-#        line: 'CleanMethod = KeepInstalled & KeepCurrent'
-#      - regexp: '^#UseDelta    = 0\.7$'
-#        line: 'UseDelta    = 0.7'
-#      - regexp: '^#Color$'
-#        line: 'Color'
-#      - regexp: '^#TotalDownload$'
-#        line: 'TotalDownload'
-#      - regexp: '^#\[multilib\]$'
-#        line: '[multilib]'
-#      - regexp:
+# - name: pacman.conf
+#   ansible.builtin.lineinfile:
+#     path: /etc/pacman.conf
+#     regexp: "{{ item.regexp }}"
+#     line: "{{ item.line }}"
+#   with_items: lines
+#   vars:
+#     lines:
+#       - regexp: '^#CleanMethod = KeepInstalled$'
+#         line: 'CleanMethod = KeepInstalled & KeepCurrent'
+#       - regexp: '^#UseDelta    = 0\.7$'
+#         line: 'UseDelta    = 0.7'
+#       - regexp: '^#Color$'
+#         line: 'Color'
+#       - regexp: '^#TotalDownload$'
+#         line: 'TotalDownload'
+#       - regexp: '^#\[multilib\]$'
+#         line: '[multilib]'
+#       - regexp:
 
 
 - name: pacman.conf

diff --git a/playbooks/roles/create_aur_user/tasks/main.yml b/playbooks/roles/create_aur_user/tasks/main.yml
@@ -22,6 +22,7 @@
     path: /etc/sudoers.d/11-install-aur_builder
     line: "{{ aur_user }} ALL=(ALL) NOPASSWD: /usr/bin/pacman"
     create: true
+    mode: "0600"
     validate: 'visudo -cf %s'
   become: true
   tags:
@@ -30,6 +31,7 @@
 
 - name: Add Tor Browser gpg key
   ansible.builtin.command: gpg --keyserver hkp://keys.openpgp.org:11371 --recv-keys 0xE53D989A9E2D47BF
+  changed_when: false
   become: true
   become_user: "{{ aur_user }}"
   tags:

diff --git a/playbooks/roles/deadbeef/tasks/main.yml b/playbooks/roles/deadbeef/tasks/main.yml
@@ -1,5 +1,6 @@
 ---
-- ansible.builtin.include_tasks:
+- name: Install deadbeef on Arch
+  ansible.builtin.include_tasks:
     file: do_install_deadbeef.yml
   when: arch in ansible_distribution
   tags:
@@ -11,6 +12,7 @@
   ansible.builtin.file:
     path: $HOME/.config/deadbeef
     state: directory
+    mode: "0755"
   tags:
     - configure_deadbeef
     - deadbeef
@@ -20,6 +22,7 @@
   ansible.builtin.copy:
     src: deadbeef/config
     dest: $HOME/.config/deadbeef/
+    mode: "0644"
   tags:
     - configure_deadbeef
     - deadbeef
diff --git a/playbooks/roles/filezilla/tasks/main.yml b/playbooks/roles/filezilla/tasks/main.yml
@@ -1,5 +1,6 @@
 ---
-- ansible.builtin.include_tasks:
+- name: Install filezilla on Arch
+  ansible.builtin.include_tasks:
     file: do_install_filezilla.yml
   when: arch in ansible_distribution
   tags:
@@ -11,6 +12,7 @@
   ansible.builtin.file:
     path: $HOME/.config/filezilla
     state: directory
+    mode: "0755"
   tags:
     - configure_filezilla
     - filezilla
@@ -20,6 +22,7 @@
   ansible.builtin.copy:
     src: sitemanager.xml
     dest: $HOME/.config/filezilla/
+    mode: "0644"
   tags:
     - configure_filezilla
     - filezilla