Improve debug output direction fitter #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerd-bouma
requested changes
Jul 7, 2023
Comment on lines
+253
to
+254
| mean_sim_az = np.angle(np.mean(temp_complex_representation.real)+ 1j * np.mean(temp_complex_representation.imag)) | ||
| std_sim_az = np.angle(np.std(temp_complex_representation.real)+ 1j * np.std(temp_complex_representation.imag)) |
There was a problem hiding this comment.
First line could in principle be simplified (the two means are additive), and I'm not sure the second one is correct - Wikipedia backed up my some toy Monte Carlo suggests
std_sim_az = np.sqrt(np.log(1/np.mean(temp_complex_representation)**2))
Comment on lines
+1
to
+4
| try: | ||
| import NuRadioReco.eventbrowser.dataprovider_root | ||
| except: | ||
| print("can't import RNO-G root reader") |
There was a problem hiding this comment.
The dataprovider_root has not yet been updated for the new RNO-G reader, and we've already removed the old one, leading to this error. This is already fixed on rnog_eventbrowser, I can make a PR next week. But it's probably okay to leave it like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves output of correlation DirectionFitter to calcualate angular differences better.
Also fixed hardcoded RNO-G specific import