Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #241

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Bug fix #241

merged 3 commits into from
Feb 26, 2025

Conversation

spinosaphb
Copy link
Contributor

@spinosaphb spinosaphb commented Feb 26, 2025

Status

READY

Background context

  • In fklearn there was a bug in the build_pipeline function that was probably exposed with the bump of new versions of libraries like numpy and pandas.
  • Also, in the latest version of lightgbm(4.6.0) there are break changes. The feature_names parameter was removed.

Description of the changes proposed in the pull request

  • Fix function _has_one_unfilled_arg in build_pipeline to correctly check the default value of the parameters
  • Restricts the maximum version of lightgbm to 4.5

… default value of the parameters

Restricts the maximum version of lightgbm to 4.5
@spinosaphb spinosaphb requested a review from a team as a code owner February 26, 2025 18:15
@spinosaphb spinosaphb merged commit 8c15e83 into master Feb 26, 2025
9 checks passed
@spinosaphb spinosaphb deleted the bug_fix branch February 26, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants