Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load and display logs in dashboard #1945

Merged

Conversation

ebrehault
Copy link
Collaborator

No description provided.

@ebrehault ebrehault requested a review from a team as a code owner February 5, 2025 15:43
toggle(url?: string) {
if (url) {
from(fetch(url).then((res) => res.text())).subscribe((ndjson) => {
console.log(ndjson);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it on purpose ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, useless code

@@ -29,24 +29,39 @@ <h1>{{ 'navbar.activity' | translate }}</h1>
</pa-tabs>
<div class="download-list">
@for (item of activity[selectedActivityTab] | async; track item.month) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I wrote this line wrong.
Could we change it to ; track selectedActivityTab + item.month ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@ebrehault ebrehault merged commit 944e4f4 into main Feb 5, 2025
2 of 3 checks passed
@ebrehault ebrehault deleted the ericbrehault/sc-11623/display-activity-log-file-in-dashboard branch February 5, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants