Blood: Fix shadows crashing when rendered in mirrors #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmyqlfpir
force-pushed
the
fix-mirror-shadow-rendering
branch
6 times, most recently
from
c340cdb to
b94b2db
Compare
tmyqlfpir
force-pushed
the
fix-mirror-shadow-rendering
branch
5 times, most recently
from
930e8fe to
8110a56
Compare
tmyqlfpir
force-pushed
the
fix-mirror-shadow-rendering
branch
from
8110a56 to
9fc13fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes crashes when attempting to render shadows in mirror sectors, and improves the overall robustness for testing fake floors below the object casting a shadow. I've tested this with Bloodlines E1M1's fake floor, and Blood E2M5's fake floor in the house lobby.
The below pic would crash with the currently released build, this has since been fixed.