Blood: Don't override sprite palette for floorpal 0 sectors #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmyqlfpir
force-pushed
the
fix-fix-colors-again
branch
from
3c959c4 to
8ae1d7e
Compare
tmyqlfpir
force-pushed
the
fix-fix-colors-again
branch
from
8ae1d7e to
b9ef35b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the original fix that commit 0d7bcf0 resolves while also fixing an edge case for non-dude sprites and overall being clearer to understand.
Fixes the vanilla bug where a floor pal 0 overrides sprites that purposefully use a non 0 palette (such as tommy cultists in E3M2).
Addresses issue #385 correctly.