fix: require specifying event time when dropping a message using source transformer #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce transformer Signed-off-by: Keran Yang <[email protected]>
…ing source transformer" This reverts commit 913ca4f.
Signed-off-by: Keran Yang <[email protected]>
vigith
reviewed
Dec 4, 2023
vigith
reviewed
Dec 4, 2023
pkg/sourcetransformer/messaget.go
Outdated
Comment on lines
64
to
75
| // Deprecated: message created using this function will not have a valid eventTime, hence excluded from watermark calculation. | ||
| // Even though a message is dropped, it is still considered as being processed, hence the watermark should be updated accordingly. | ||
| // Since v0.5.2, we recommend using MessageToDropWithEventTime instead. | ||
| func MessageToDrop() Message { | ||
| return Message{eventTime: eventTimeForDrop, value: []byte{}, tags: []string{DROP}} | ||
| } | ||
|
|
||
| // MessageToDropWithEventTime creates a Message to be dropped with eventTime | ||
| func MessageToDropWithEventTime(eventTime time.Time) Message { | ||
| return Message{eventTime: eventTime, value: []byte{}, tags: []string{DROP}} | ||
| } | ||
|
|
There was a problem hiding this comment.
what if, if we make this a breaking change and MessageToDrop needs event-time?
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
vigith
approved these changes
Dec 4, 2023
yhl25
pushed a commit
that referenced
this pull request
Dec 7, 2023
…ce transformer (#90) Signed-off-by: Keran Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.