Ajoute un bouton FranceConnect aux normes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabinout
commented
May 28, 2024
| {{/avecConnexionFCPlus}} | ||
|
|
||
| {{^avecConnexionFCPlus}} | ||
| <p>Pas d'utilisateur courant</p> | ||
| <p>Pas d'utilisateur courant</p> |
There was a problem hiding this comment.
J'ai corrigé l'indentation du fichier moustache, ça aurait pu être séparé dans un commit différent
Fabinout
commented
May 28, 2024
src/vues/pageAccueil.mustache
Outdated
| {{^infosUtilisateur}} | ||
| <p>Pas d'utilisateur courant</p> | ||
| <!-- <a href="/auth/fcplus/creationSession">Connexion</a>--> | ||
| <div class="container"> |
Fabinout
commented
May 28, 2024
src/vues/pageAccueil.mustache
Outdated
| <div class="container"> | ||
| <p>FranceConnect est la solution proposée par l’État pour sécuriser et simplifier la connexion à vos | ||
| services en ligne.</p> | ||
| <button class="franceconnect-button"> |
Fabinout
commented
May 28, 2024
src/vues/pageAccueil.mustache
Outdated
| <button class="franceconnect-button"> | ||
| <a href="/auth/fcplus/creationSession"></a> | ||
| </button> | ||
| <a href="https://franceconnect.gouv.fr/">Qu'est-ce que FranceConnect? </a> |
There was a problem hiding this comment.
Rajouter icone de redirection + nouvel onglet
Fabinout
commented
May 28, 2024
Fabinout
commented
May 28, 2024
Fabinout
force-pushed
the
bouton-fc
branch
3 times, most recently
from
b37b701 to
9df6500
Compare
egaillot
reviewed
Jun 3, 2024
There was a problem hiding this comment.
En termes de standards, je préfère que par défaut, et avant besoins de factorisation on nomme la page de style avec le même nom que la page template. En l'occurrence : pageAccueil.css
src/vues/pageAccueil.mustache
Outdated
| services en ligne.</p> | ||
| <a class="bouton-franceconnect" href="/auth/fcplus/creationSession" > | ||
| </a> | ||
| <a href="https://franceconnect.gouv.fr/" target="_blank">Qu'est-ce que FranceConnect? <img src="statique/assets/images/square.svg" alt="Icône de lien"/></a> |
There was a problem hiding this comment.
Dès qu'on aura deux liens avec cette image, je propose qu'on utilise plutôt un style CSS avec un ::after.
egaillot
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.partenaires.franceconnect.gouv.fr/fs/integration-graphique/integration-bouton-fc/