-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Attempt to build using spin #114
BLD: Attempt to build using spin #114
Conversation
This commit is the first commit to try and move from poetry to spin. It is not working at the moment, namely the test runner cannot find the given tests.
I'm not sure what the preferred practice is, but it fixes pytest test discovery. See https://stackoverflow.com/a/41752043/214686
With these changes, it now builds and tests on my machine; I am running into some numpy 2.0 issues, so those will still have to be addressed separately. |
I see you're using ruff for linting. Providing a pre-commit hook would be helpful (or a custom hook, like SciPy, is fine too). |
Errors I see locally:
|
Thanks heaps for helping out. I think I can take it from here. I don't think those are NumPy 2.0 issues. They are just from me not having templated the Cython code fully yet. I'll take a look at it now |
At the moment we have only templated the Cython code to work with ``double``s. This may need to be changed in the future.
This commit is the first commit to try and move from poetry to spin.
It is not working at the moment, namely the test runner cannot find the given tests.