Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sebastian/diff 6.0 #692

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

IsraelPinheiro
Copy link
Contributor

@IsraelPinheiro IsraelPinheiro commented Sep 10, 2024

Q A
Bug fix? no
New feature? yes
Fixed tickets #678 #676 #693

Add support to the newest sebastian/diff version

@RSickenberg
Copy link

@nunomaduro Please merge :)

@IsraelPinheiro
Copy link
Contributor Author

IsraelPinheiro commented Sep 11, 2024

@cmgmyr @Jibbarth @JustSteveKing - Could you check this ? Currently phpinsights is unusable with Laravel 11, pending this PR to work again

@leonardyrj
Copy link

wip

@brandonferens
Copy link

Any word or progress on this? This issue is holding up my ability to upgrade to Pest v3. At the moment it isn't possible to run Pest v3, Insights, and PHPunit 11 together because of conflicting sebastian/diff versions.

@Sergiobop
Copy link

Sadly, despite being an amazing package, it is kinda abandoned

Anything we can do to help here? I think this PR is very simple and should be easy to merge

@brandonferens
Copy link

Agreed @Sergiobop.

@cmgmyr, @Jibbarth, or @JustSteveKing has this project been abandoned? I like this package but understand if it has come to the end of life. I would just like to know how to proceed. Thanks!

@Jibbarth
Copy link
Collaborator

Hi all !

Sorry for the delay 😓, but thanks for the ping :)

Let's merge it and let me check to see if there is any other dependencies that can be updated.

@Jibbarth Jibbarth merged commit e3f0a40 into nunomaduro:master Oct 13, 2024
50 of 53 checks passed
@Jibbarth Jibbarth added the dependencies Pull requests that update a dependency file label Oct 13, 2024
@IsraelPinheiro IsraelPinheiro deleted the feature/sebastian-diff-6 branch November 4, 2024 23:34
@ond-danny
Copy link

@IsraelPinheiro @Jibbarth

When will this be available as a release? I notice it's been merged but release is still at v2.11 back last year.

We have upgraded to Laravel 11 but this incompatibility is holding back upgrade of phpunit. Since upgrade out test packages don't execute properly so I'd like to get phpunit and insights updated.

@elnur-ibr
Copy link
Contributor

That issue holding us back to upgrade phpunit. Does anyone know when it could be released?

@cmgmyr
Copy link
Collaborator

cmgmyr commented Nov 11, 2024

@elnur-ibr just tagged v2.12.0

@brandonferens
Copy link

Thanks! I'm back up and running with Insights!

@ond-danny
Copy link

Wonderful thanks for this :)

@girardotcl
Copy link

Thank you so much ! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants