[W5.7][F11-1]Wu Jiacheng #440
Conversation
…ons in the address book.
docs/UserGuide.adoc
Outdated
| == Display total number of persons in address book : `total` | ||
|
|
||
| Shows the total number of persons in the address book. + | ||
| Format: `list` |
There was a problem hiding this comment.
Why is the format for total command list?
There was a problem hiding this comment.
It's a error. Thanks for pointing it out.
|
|
||
| public static final String MESSAGE_USAGE = COMMAND_WORD | ||
| + ": display the total number of persons stored in the address book.\n" | ||
| + "Example: " + COMMAND_WORD; |
There was a problem hiding this comment.
Nice! I did not think of explaining what the total command does in my own implementation. Oversight on my part :(. I totally assumed it would be similar to the clear and/or list command(s)
| * Gets total number of persons in list. | ||
| */ | ||
| public int getTotal() { return allPersons.getSize(); } | ||
|
|
There was a problem hiding this comment.
Nice naming of getter method as getTotal(). For me, I called it getSize() both in this file and src/seedu/addressbook/data/person/UniquePersonList.java :(
| + ": display the total number of persons stored in the address book.\n" | ||
| + "Example: " + COMMAND_WORD; | ||
|
|
||
| public static final String MESSAGE_TOTAL_IN_ADDRESSBOOK = "There is/are %1$s person(s) in the address book"; |
There was a problem hiding this comment.
I liked your usage of %1$s in the MESSAGE_TOTAL_IN_ADDRESSBOOK String constant :)
| /** | ||
| * Gets total number of persons in list. | ||
| */ | ||
| public int getSize() { return internalList.size(); } |
There was a problem hiding this comment.
Formatting issue, please check coding standard
PR for LO ID W5.7