[W5.7][F11-3]Cai Jiaxiu #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! But would be best to add test coverage as well. |
jelneo
approved these changes
Sep 15, 2018
| @@ -61,7 +61,7 @@ public Address getAddress() { | |||
| public Set<Tag> getTags() { | |||
| return new HashSet<>(tags); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Unnecessary space. Ensure that you look through the changes to the code before you stage a file for commit.
| } | ||
|
|
||
| /** | ||
| * set the original and updated person |
There was a problem hiding this comment.
Standardize header comments by ensuring all comments start with a capital letter.
| setUpdatedPerson(); | ||
| addressBook.updatePerson(original, toUpdate); | ||
| return new CommandResult(String.format(MESSAGE_UPDATE_PERSON_SUCCESS, toUpdate)); | ||
|
|
| @@ -148,15 +162,56 @@ private static boolean isPrivatePrefixPresent(String matchedPrefix) { | |||
| */ | |||
| private static Set<String> getTagsFromArgs(String tagArguments) throws IllegalValueException { | |||
| // no tags | |||
| if (tagArguments.isEmpty()) { | |||
| if (tagArguments.isEmpty() || tagArguments.trim().isEmpty()) { | |||
There was a problem hiding this comment.
This condition can be simplified to just tagArguments.trim().isEmpty() since trim() just removes leading and trailing whitespace in tagArguments
| @@ -9,6 +9,9 @@ | |||
| || add: Adds a person to the address book. Contact details can be marked private by prepending 'p' to the prefix. | |||
| || Parameters: NAME [p]p/PHONE [p]e/EMAIL [p]a/ADDRESS [t/TAG]... | |||
| || Example: add John Doe p/98765432 e/[email protected] a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney | |||
| || update: Updates a person identified by the index number used in the last person listing. | |||
| || Parameters: INDEX [[p]p/PHONE] [[p]e/EMAIL] [[p]a/ADDRESS] [t/TAG]... | |||
| @@ -294,6 +295,69 @@ private static String convertPersonToAddCommandString(ReadOnlyPerson person) { | |||
| return addCommand; | |||
| } | |||
|
|
|||
| /* | |||
| * Tests for update person command ============================================================================== | |||
There was a problem hiding this comment.
there's no need to write header comments for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.