Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W5.7][F10-1]Raynard Hadiwidjaja #449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[W5.7][F10-1]Raynard Hadiwidjaja #449

wants to merge 1 commit into from

Conversation

RnardHa
Copy link

@RnardHa RnardHa commented Sep 13, 2018

Update the find function, so it is not case sensitive anymore.
Updated user guide.
Updated the expected I/O testing.

@RnardHa
Update the find function, so it is not case sensitive anymore.
603b9ca 
Updated user giude.
Updated the expected I/O testing.
@wn
Copy link

wn commented Sep 13, 2018

Commit message shouldn't have full stops.

jlks96
jlks96 approved these changes Sep 13, 2018
View reviewed changes
Copy link

@jlks96 jlks96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on attempting the LO. Maybe you can update the User Guide a little more to indicate that the search is case insensitive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlks96 jlks96 jlks96 approved these changes

Assignees

@jlks96 jlks96

Labels
Reviewed team.1 tutorial.F10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RnardHa @wn @jlks96 @nus-se-pr-bot