[W5.7][F11-2]Chew Yong Soon #457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good stuff! Proper coding standards followed! |
teowz46
reviewed
Sep 13, 2018
|
|
||
|
|
||
| /** | ||
| * Lists all persons in the address book to the user. |
| import seedu.addressbook.commands.ListCommand; | ||
| import seedu.addressbook.commands.ViewAllCommand; | ||
| import seedu.addressbook.commands.ViewCommand; | ||
| import seedu.addressbook.commands.*; |
There was a problem hiding this comment.
Are we allowed to do this? If not I think you may need to tweak the behaviour of Alt-Enter in Intellij if you wish to use the shortcut.
There was a problem hiding this comment.
Do not use wild cards, show each import explicitly. Check coding convention.
liliwei25
approved these changes
Sep 16, 2018
|
|
||
|
|
||
| /** | ||
| * Lists all persons in the address book to the user. |
| public CommandResult execute() { | ||
| try { | ||
| addressBook.sort((ReadOnlyPerson p1, ReadOnlyPerson p2) -> { | ||
| switch (keyword) { |
There was a problem hiding this comment.
Check the coding standard for switch statements
| @@ -13,6 +13,9 @@ | |||
| * Returns true if any of the given items are null. | |||
| */ | |||
| public static boolean isAnyNull(Object... items) { | |||
| if (items == null) { | |||
| import seedu.addressbook.commands.ListCommand; | ||
| import seedu.addressbook.commands.ViewAllCommand; | ||
| import seedu.addressbook.commands.ViewCommand; | ||
| import seedu.addressbook.commands.*; |
There was a problem hiding this comment.
Do not use wild cards, show each import explicitly. Check coding convention.
| @@ -34,6 +34,15 @@ public void elementsAreUnique() throws Exception { | |||
| assertNotUnique(null, 1, Integer.valueOf(1)); | |||
| assertNotUnique(null, null); | |||
| assertNotUnique(null, "a", "b", null); | |||
|
|
|||
| // some empty objects | |||
There was a problem hiding this comment.
Unrelated code changes? Please refrain for adding unrelated code changes to your future PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.