[W5.7][F11-2] Neil Mehta #459
Conversation
|
Hi @neilish3re, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
neilish3re
changed the title
| import seedu.addressbook.data.person.Person; | ||
| import seedu.addressbook.data.person.ReadOnlyPerson; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
Follow coding standards. No wild cards for imports.
| import java.util.*; | ||
|
|
||
| //Sorts contact list of persons by alphabetical order | ||
| public class SortCommand extends Command{ |
|
|
||
| private final Set<String> keywords; | ||
|
|
||
| public SortCommand(Set<String> keywords){ |
| import seedu.addressbook.data.person.Person; | ||
| import seedu.addressbook.data.person.ReadOnlyPerson; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
Follow coding standards. No wild cards for imports.
|
|
||
| import java.util.*; | ||
|
|
||
| //Sorts contact list of persons by alphabetical order |
There was a problem hiding this comment.
Alphabetical order according to which attribute?
| * @param keywords for searching | ||
| * @return list of persons found | ||
| */ | ||
| private List<ReadOnlyPerson> getPersonsWithNameContainingAnyKeyword(Set<String> keywords) { |
There was a problem hiding this comment.
This is a direct copy from FindCommand. I don't think this performs any sorting.
Add Sort Command Class File (just the class file, haven't been able to parse the command yet)