[W5.7][F10-3]Ng Ee Hooi #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done! I like the size command, seems like a pretty useful feature! |
dalessr
requested changes
Sep 15, 2018
| @@ -21,7 +21,8 @@ public CommandResult execute() { | |||
| + "\n" + ListCommand.MESSAGE_USAGE | |||
| + "\n" + ViewCommand.MESSAGE_USAGE | |||
| + "\n" + ViewAllCommand.MESSAGE_USAGE | |||
| + "\n" + HelpCommand.MESSAGE_USAGE | |||
| + "\n" + HelpCommand.MESSAGE_USAGE | |||
| import seedu.addressbook.commands.ListCommand; | ||
| import seedu.addressbook.commands.ViewAllCommand; | ||
| import seedu.addressbook.commands.ViewCommand; | ||
| import seedu.addressbook.commands.*; |
There was a problem hiding this comment.
Coding standard violation here. Need to specify all classes used in this file
| @@ -90,20 +88,22 @@ public void save(AddressBook addressBook) throws StorageOperationException { | |||
| */ | |||
| public AddressBook load() throws StorageOperationException { | |||
|
|
|||
| if (!Files.exists(path) || !Files.isRegularFile(path)) { | |||
| if (path.getFileSystem().isReadOnly() || !Files.exists(path) || !Files.isRegularFile(path)) { | |||
| @@ -10,6 +10,36 @@ | |||
|
|
|||
| public class UtilsTest { | |||
|
|
|||
| @Test | |||
| public void isAnyNull() throws Exception { | |||
There was a problem hiding this comment.
Same as above. Always remember to create a new branch off master for each enhancement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new size command